netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikolay Aleksandrov <nikolay@redhat.com>
To: netdev@vger.kernel.org
Cc: fubar@us.ibm.com, andy@greyhouse.net, davem@davemloft.net
Subject: [PATCH -net v2 0/2] bonding: fix arp_validate desync state & race
Date: Sat,  7 Sep 2013 00:00:24 +0200	[thread overview]
Message-ID: <1378504826-18855-1-git-send-email-nikolay@redhat.com> (raw)

Hello all,
These two patches aim to fix the possible de-sync state which the bond
can enter if we have arp_validate without arp_interval or the other way
around. They also fix a race condition between arp_validate setting and
mode changing.

Patch 01 - fixes the race condition between store_arp_validate and bond
mode change by using rtnl for sync
Patch 02 - fixes the possible de-sync state by setting/unsetting recv_probe
if arp_interval is set/unset and also if arp_validate is set/unset

v2: Fix the mode check in store_arp_validate

Best regards,
 Nikolay Aleksandrov


Nikolay Aleksandrov (2):
  bonding: fix store_arp_validate race with mode change
  bonding: fix bond_arp_rcv setting and arp validate desync state

 drivers/net/bonding/bond_main.c  |  4 ++--
 drivers/net/bonding/bond_sysfs.c | 31 +++++++++++++++++++++++++------
 drivers/net/bonding/bonding.h    |  1 +
 3 files changed, 28 insertions(+), 8 deletions(-)

-- 
1.8.1.4

             reply	other threads:[~2013-09-06 22:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06 22:00 Nikolay Aleksandrov [this message]
2013-09-06 22:00 ` [PATCH -net v2 1/2] bonding: fix store_arp_validate race with mode change Nikolay Aleksandrov
2013-09-10 18:15   ` [-net,v2,1/2] " Veaceslav Falico
2013-09-06 22:00 ` [PATCH -net v2 2/2] bonding: fix bond_arp_rcv setting and arp validate desync state Nikolay Aleksandrov
2013-09-10 14:48   ` Marcelo Ricardo Leitner
2013-09-10 18:20   ` [-net, v2, " Veaceslav Falico
2013-09-11 19:55 ` [PATCH -net v2 0/2] bonding: fix arp_validate desync state & race David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378504826-18855-1-git-send-email-nikolay@redhat.com \
    --to=nikolay@redhat.com \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=fubar@us.ibm.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).