Netdev List
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: <netdev@vger.kernel.org>, <linux-net-drivers@solarflare.com>
Subject: Re: [PATCH 1/1] sfc: Staticize efx_ethtool_get_ts_info
Date: Tue, 10 Sep 2013 13:08:11 +0100	[thread overview]
Message-ID: <1378814891.32513.29.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <1378806210-12155-1-git-send-email-sachin.kamat@linaro.org>

On Tue, 2013-09-10 at 15:13 +0530, Sachin Kamat wrote:
> 'efx_ethtool_get_ts_info' is used only in this file.
> Make it static.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/net/ethernet/sfc/ethtool.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sfc/ethtool.c b/drivers/net/ethernet/sfc/ethtool.c
> index 5b471cf..c8dc407 100644
> --- a/drivers/net/ethernet/sfc/ethtool.c
> +++ b/drivers/net/ethernet/sfc/ethtool.c
> @@ -1035,8 +1035,8 @@ static int efx_ethtool_set_rxfh_indir(struct net_device *net_dev,
>  	return 0;
>  }
>  
> -int efx_ethtool_get_ts_info(struct net_device *net_dev,
> -			    struct ethtool_ts_info *ts_info)
> +static int efx_ethtool_get_ts_info(struct net_device *net_dev,
> +				   struct ethtool_ts_info *ts_info)
>  {
>  	struct efx_nic *efx = netdev_priv(net_dev);
>  

I already have this fix, but net-next is not open for changes.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

  reply	other threads:[~2013-09-10 12:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-10  9:43 [PATCH 1/1] sfc: Staticize efx_ethtool_get_ts_info Sachin Kamat
2013-09-10 12:08 ` Ben Hutchings [this message]
2013-09-11  4:43   ` Sachin Kamat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378814891.32513.29.camel@deadeye.wl.decadent.org.uk \
    --to=bhutchings@solarflare.com \
    --cc=linux-net-drivers@solarflare.com \
    --cc=netdev@vger.kernel.org \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox