From: Ben Hutchings <bhutchings@solarflare.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: <netdev@vger.kernel.org>, <linux-net-drivers@solarflare.com>
Subject: Re: [PATCH 1/1] sfc: Staticize efx_ef10_filter_update_rx_scatter
Date: Tue, 10 Sep 2013 13:08:43 +0100 [thread overview]
Message-ID: <1378814923.32513.30.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <1378806567-30625-1-git-send-email-sachin.kamat@linaro.org>
On Tue, 2013-09-10 at 15:19 +0530, Sachin Kamat wrote:
> 'efx_ef10_filter_update_rx_scatter' is used only in this file.
> Make it static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/net/ethernet/sfc/ef10.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
> index 5f42313..6956bd2 100644
> --- a/drivers/net/ethernet/sfc/ef10.c
> +++ b/drivers/net/ethernet/sfc/ef10.c
> @@ -2121,7 +2121,7 @@ out_unlock:
> return rc;
> }
>
> -void efx_ef10_filter_update_rx_scatter(struct efx_nic *efx)
> +static void efx_ef10_filter_update_rx_scatter(struct efx_nic *efx)
> {
> /* no need to do anything here on EF10 */
> }
Same for this.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
prev parent reply other threads:[~2013-09-10 12:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 9:49 [PATCH 1/1] sfc: Staticize efx_ef10_filter_update_rx_scatter Sachin Kamat
2013-09-10 12:08 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378814923.32513.30.camel@deadeye.wl.decadent.org.uk \
--to=bhutchings@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox