* [PATCH 1/1] resubmit bridge: fix message_age_timer calculation
@ 2013-09-12 4:37 Chris Healy
2013-09-13 3:31 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Chris Healy @ 2013-09-12 4:37 UTC (permalink / raw)
To: Stephen Hemminger, David S. Miller; +Cc: bridge, netdev, buytenh, Chris Healy
This changes the message_age_timer calculation to use the BPDU's max age as
opposed to the local bridge's max age. This is in accordance with section
8.6.2.3.2 Step 2 of the 802.1D-1998 sprecification.
With the current implementation, when running with very large bridge
diameters, convergance will not always occur even if a root bridge is
configured to have a longer max age.
Tested successfully on bridge diameters of ~200.
Signed-off-by: Chris Healy <cphealy@gmail.com>
---
net/bridge/br_stp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c
index 1c0a50f..f1887ba 100644
--- a/net/bridge/br_stp.c
+++ b/net/bridge/br_stp.c
@@ -209,7 +209,7 @@ static void br_record_config_information(struct net_bridge_port *p,
p->designated_age = jiffies - bpdu->message_age;
mod_timer(&p->message_age_timer, jiffies
- + (p->br->max_age - bpdu->message_age));
+ + (bpdu->max_age - bpdu->message_age));
}
/* called under bridge lock */
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] resubmit bridge: fix message_age_timer calculation
2013-09-12 4:37 [PATCH 1/1] resubmit bridge: fix message_age_timer calculation Chris Healy
@ 2013-09-13 3:31 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-09-13 3:31 UTC (permalink / raw)
To: cphealy; +Cc: stephen, netdev, bridge, buytenh
From: Chris Healy <cphealy@gmail.com>
Date: Wed, 11 Sep 2013 21:37:47 -0700
> This changes the message_age_timer calculation to use the BPDU's max age as
> opposed to the local bridge's max age. This is in accordance with section
> 8.6.2.3.2 Step 2 of the 802.1D-1998 sprecification.
>
> With the current implementation, when running with very large bridge
> diameters, convergance will not always occur even if a root bridge is
> configured to have a longer max age.
>
> Tested successfully on bridge diameters of ~200.
>
> Signed-off-by: Chris Healy <cphealy@gmail.com>
Applied and queued up for -stable, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-13 3:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-12 4:37 [PATCH 1/1] resubmit bridge: fix message_age_timer calculation Chris Healy
2013-09-13 3:31 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).