From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [ethtool 1/3] ethtool: fix ixgbe 82598EB only registers Date: Thu, 12 Sep 2013 16:45:29 +0100 Message-ID: <1379000729.1531.12.camel@bwh-desktop.uk.level5networks.com> References: <1377648529-8297-1-git-send-email-jeffrey.t.kirsher@intel.com> <1377809470.5372.16.camel@bwh-desktop.uk.level5networks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Jacob Keller , , , To: Jeff Kirsher Return-path: Received: from webmail.solarflare.com ([12.187.104.25]:57209 "EHLO webmail.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754282Ab3ILPxt (ORCPT ); Thu, 12 Sep 2013 11:53:49 -0400 In-Reply-To: <1377809470.5372.16.camel@bwh-desktop.uk.level5networks.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 2013-08-29 at 21:51 +0100, Ben Hutchings wrote: > On Tue, 2013-08-27 at 17:08 -0700, Jeff Kirsher wrote: > > From: Jacob Keller > > > > This patch fixes ixgbe_reg_dump to only display registers specific to the > > 82598EB part, as these registers display 0xDEADBEEF otherwise, and clutter up > > the register dump. > > > > Signed-off-by: Jacob Keller > > Tested-by: Phil Schmitt > > Signed-off-by: Jeff Kirsher > > --- > > ixgbe.c | 144 +++++++++++++++++++++++++++++++++------------------------------- > > 1 file changed, 75 insertions(+), 69 deletions(-) > > > > diff --git a/ixgbe.c b/ixgbe.c > > index 9b005f2..89cb6be 100644 > > --- a/ixgbe.c > > +++ b/ixgbe.c > [...] > > - fprintf(stdout, > > - "0x02F20: RDPROBE (Rx Probe Mode Status) 0x%08X\n", > > - regs_buff[1085]); > [...] > > It looks like this removal really belongs to the next patch, which adds > it back with the mac_type < ixgbe_mac_X540 condition. Well, I've applied the two patches with this bit fixed up. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.