From: Eric Dumazet <eric.dumazet@gmail.com>
To: vyasevic@redhat.com
Cc: Hong zhi guo <honkiko@gmail.com>,
netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
zhiguohong@tencent.com
Subject: Re: [PATCH net-next] fix NULL pointer dereference in br_handle_frame
Date: Thu, 12 Sep 2013 09:08:58 -0700 [thread overview]
Message-ID: <1379002138.24408.17.camel@edumazet-glaptop> (raw)
In-Reply-To: <5231E2C7.1010106@redhat.com>
On Thu, 2013-09-12 at 11:50 -0400, Vlad Yasevich wrote:
> On 09/12/2013 11:24 AM, Eric Dumazet wrote:
> > On Thu, 2013-09-12 at 10:42 -0400, Vlad Yasevich wrote:
> >
> >> Don't all tests for IFF_BRIDGE_PORT on the bridge receive path become
> >> redundant as well?
> >
> > Sure but anyway this part is net-next material
> >
> > Lets fix the bug first.
>
> Seems like the race is possible in net as well. If we just include the
> original patch, then br_add_if() also has to be modified to make sure
> the flag is set properly before netdev_rx_handler_register() is called.
>
> If we remove the need to check the flag during bridge input handling,
> then br_add_if() change is not necessary.
Yep, really testing IFF_BRIDGE_PORT in fast path is currently racy.
rcu protection should be enough.
next prev parent reply other threads:[~2013-09-12 16:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 12:16 [PATCH net-next] fix NULL pointer dereference in br_handle_frame Hong Zhiguo
2013-09-12 14:11 ` Eric Dumazet
2013-09-12 14:24 ` Hong zhi guo
2013-09-12 14:33 ` Eric Dumazet
2013-09-12 14:42 ` Vlad Yasevich
2013-09-12 15:24 ` Eric Dumazet
2013-09-12 15:50 ` Vlad Yasevich
2013-09-12 16:08 ` Eric Dumazet [this message]
2013-09-12 15:57 ` Hong Zhiguo
2013-09-12 16:06 ` Hong zhi guo
2013-09-12 16:11 ` Eric Dumazet
2013-09-12 16:18 ` Hong zhi guo
2013-09-12 16:19 ` Eric Dumazet
2013-09-12 16:12 ` Eric Dumazet
2013-09-12 19:18 ` David Miller
2013-09-13 3:09 ` [PATCH net-next] bridge: fix NULL pointer deref " Hong Zhiguo
2013-09-13 16:21 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379002138.24408.17.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=honkiko@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
--cc=zhiguohong@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox