Netdev List
 help / color / mirror / Atom feed
From: Prarit Bhargava <prarit@redhat.com>
To: netdev@vger.kernel.org
Cc: Prarit Bhargava <prarit@redhat.com>,
	dzickus@redhat.com, Karsten Keil <isdn@linux-pingi.de>
Subject: [PATCH] ISDN, hfcpci Fix uninitialized warning
Date: Fri, 13 Sep 2013 08:28:16 -0400	[thread overview]
Message-ID: <1379075296-19976-1-git-send-email-prarit@redhat.com> (raw)

Fix uninitialized warning.  Use same fix as
drivers/media/pci/cx18/cx18-alsa-main.c

  CC [M]  drivers/isdn/hardware/mISDN/hfcpci.o
  drivers/isdn/hardware/mISDN/hfcpci.c: In function ‘hfcpci_softirq’:
  drivers/isdn/hardware/mISDN/hfcpci.c:2298:2: error: ignoring return
  value of ‘driver_for_each_device’, declared with attribute
  warn_unused_result [-Werror=unused-result]
    (void) driver_for_each_device(&hfc_driver.driver, NULL, arg,
		      ^

Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Cc: dzickus@redhat.com
Cc: Karsten Keil <isdn@linux-pingi.de>
---
 drivers/isdn/hardware/mISDN/hfcpci.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c
index 7f910c7..2373b44 100644
--- a/drivers/isdn/hardware/mISDN/hfcpci.c
+++ b/drivers/isdn/hardware/mISDN/hfcpci.c
@@ -2295,8 +2295,12 @@ _hfcpci_softirq(struct device *dev, void *arg)
 static void
 hfcpci_softirq(void *arg)
 {
-	(void) driver_for_each_device(&hfc_driver.driver, NULL, arg,
+	int ret;
+
+	ret = driver_for_each_device(&hfc_driver.driver, NULL, arg,
 				      _hfcpci_softirq);
+	if (unlikely(ret))
+		pr_warn("hfcpci_softirq: driver softirq failed\n");
 
 	/* if next event would be in the past ... */
 	if ((s32)(hfc_jiffies + tics - jiffies) <= 0)
-- 
1.7.9.3

                 reply	other threads:[~2013-09-13 12:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379075296-19976-1-git-send-email-prarit@redhat.com \
    --to=prarit@redhat.com \
    --cc=dzickus@redhat.com \
    --cc=isdn@linux-pingi.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox