netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Prarit Bhargava <prarit@redhat.com>
To: netdev@vger.kernel.org
Cc: Prarit Bhargava <prarit@redhat.com>,
	jpirko@redhat.com, tgraf@redhat.com,
	"David S. Miller" <davem@davemloft.net>
Subject: [PATCH] net, vxlan Fix compile warning
Date: Fri, 13 Sep 2013 08:29:12 -0400	[thread overview]
Message-ID: <1379075352-20051-1-git-send-email-prarit@redhat.com> (raw)

Fix a unintialized variable warning.

drivers/net/vxlan.c: In function ‘vxlan_sock_add’:
drivers/net/vxlan.c:2240:11: error: ‘sock’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  vs->sock = sock;
           ^
drivers/net/vxlan.c:2217:17: note: ‘sock’ was declared here
  struct socket *sock;
                 ^

Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Cc: jpirko@redhat.com
Cc: tgraf@redhat.com
Cc: "David S. Miller" <davem@davemloft.net>
---
 drivers/net/vxlan.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index bf64b41..ed3d7f4 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -2276,7 +2276,7 @@ static struct vxlan_sock *vxlan_socket_create(struct net *net, __be16 port,
 {
 	struct vxlan_net *vn = net_generic(net, vxlan_net_id);
 	struct vxlan_sock *vs;
-	struct socket *sock;
+	struct socket *uninitialized_var(sock);
 	struct sock *sk;
 	int rc = 0;
 	unsigned int h;
-- 
1.7.9.3

             reply	other threads:[~2013-09-13 12:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-13 12:29 Prarit Bhargava [this message]
2013-09-13 12:58 ` [PATCH] net, vxlan Fix compile warning Jiri Pirko
2013-09-13 14:20 ` Stephen Hemminger
2013-09-13 14:23   ` Prarit Bhargava
2013-09-13 14:40     ` Stephen Hemminger
2013-09-17  1:23 ` David Miller
2013-09-17 19:12   ` [PATCH 1/2] " Prarit Bhargava
2013-09-17 20:26     ` Ben Hutchings
2013-09-19 13:04       ` [PATCH 1/2] net, vxlan Fix compile warning [v3] Prarit Bhargava
2013-09-19 13:09         ` David Miller
2013-09-19 13:13           ` Prarit Bhargava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379075352-20051-1-git-send-email-prarit@redhat.com \
    --to=prarit@redhat.com \
    --cc=davem@davemloft.net \
    --cc=jpirko@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=tgraf@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).