* [patch -stable] igbvf: integer wrapping bug setting the mtu
@ 2013-09-13 8:37 Dan Carpenter
2013-09-13 8:58 ` David Laight
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2013-09-13 8:37 UTC (permalink / raw)
To: Jeff Kirsher
Cc: kernel-janitors, netdev, Patrick McHardy, e1000-devel,
Bruce Allan, Jesse Brandeburg, David S. Miller, John Ronciak,
Greg Kroah-Hartman
If new_mtu is very large then "new_mtu + ETH_HLEN + ETH_FCS_LEN" can
wrap and the check on the next line can underflow. This is one of those
bugs which can be triggered by the user if you have namespaces
configured.
This is a static checker fix and I'm not sure what the impact is.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c
index 95d5430..24e3883 100644
--- a/drivers/net/ethernet/intel/igbvf/netdev.c
+++ b/drivers/net/ethernet/intel/igbvf/netdev.c
@@ -2342,7 +2342,7 @@ static struct net_device_stats *igbvf_get_stats(struct net_device *netdev)
static int igbvf_change_mtu(struct net_device *netdev, int new_mtu)
{
struct igbvf_adapter *adapter = netdev_priv(netdev);
- int max_frame = new_mtu + ETH_HLEN + ETH_FCS_LEN;
+ unsigned int max_frame = new_mtu + ETH_HLEN + ETH_FCS_LEN;
if ((new_mtu < 68) || (max_frame > MAX_JUMBO_FRAME_SIZE)) {
dev_err(&adapter->pdev->dev, "Invalid MTU setting\n");
------------------------------------------------------------------------------
How ServiceNow helps IT people transform IT departments:
1. Consolidate legacy IT systems to a single system of record for IT
2. Standardize and globalize service processes across IT
3. Implement zero-touch automation to replace manual, redundant tasks
http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [patch -stable] igbvf: integer wrapping bug setting the mtu
2013-09-13 8:37 [patch -stable] igbvf: integer wrapping bug setting the mtu Dan Carpenter
@ 2013-09-13 8:58 ` David Laight
2013-09-13 9:54 ` Dan Carpenter
0 siblings, 1 reply; 6+ messages in thread
From: David Laight @ 2013-09-13 8:58 UTC (permalink / raw)
To: Dan Carpenter, Jeff Kirsher
Cc: Jesse Brandeburg, Bruce Allan, Carolyn Wyborny, Don Skidmore,
Greg Rose, Peter P Waskiewicz Jr, Alex Duyck, John Ronciak,
Tushar Dave, David S. Miller, Mitch Williams, Patrick McHardy,
Greg Kroah-Hartman, e1000-devel, netdev, kernel-janitors
> If new_mtu is very large then "new_mtu + ETH_HLEN + ETH_FCS_LEN" can
> wrap and the check on the next line can underflow. This is one of those
> bugs which can be triggered by the user if you have namespaces
> configured.
>
> This is a static checker fix and I'm not sure what the impact is.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c
> index 95d5430..24e3883 100644
> --- a/drivers/net/ethernet/intel/igbvf/netdev.c
> +++ b/drivers/net/ethernet/intel/igbvf/netdev.c
> @@ -2342,7 +2342,7 @@ static struct net_device_stats *igbvf_get_stats(struct net_device *netdev)
> static int igbvf_change_mtu(struct net_device *netdev, int new_mtu)
> {
> struct igbvf_adapter *adapter = netdev_priv(netdev);
> - int max_frame = new_mtu + ETH_HLEN + ETH_FCS_LEN;
> + unsigned int max_frame = new_mtu + ETH_HLEN + ETH_FCS_LEN;
>
> if ((new_mtu < 68) || (max_frame > MAX_JUMBO_FRAME_SIZE)) {
> dev_err(&adapter->pdev->dev, "Invalid MTU setting\n");
It is safer to check:
if ((new_mtu < 68) || (new_mtu > MAX_JUMBO_FRAME_SIZE - ETH_HLEN - ETH_FCS_LEN)) {
David
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch -stable] igbvf: integer wrapping bug setting the mtu
2013-09-13 8:58 ` David Laight
@ 2013-09-13 9:54 ` Dan Carpenter
2013-09-13 10:55 ` David Laight
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2013-09-13 9:54 UTC (permalink / raw)
To: David Laight
Cc: kernel-janitors, netdev, Patrick McHardy, e1000-devel,
Bruce Allan, Jesse Brandeburg, David S. Miller, John Ronciak,
Greg Kroah-Hartman
On Fri, Sep 13, 2013 at 09:58:25AM +0100, David Laight wrote:
> > If new_mtu is very large then "new_mtu + ETH_HLEN + ETH_FCS_LEN" can
> > wrap and the check on the next line can underflow. This is one of those
> > bugs which can be triggered by the user if you have namespaces
> > configured.
> >
> > This is a static checker fix and I'm not sure what the impact is.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c
> > index 95d5430..24e3883 100644
> > --- a/drivers/net/ethernet/intel/igbvf/netdev.c
> > +++ b/drivers/net/ethernet/intel/igbvf/netdev.c
> > @@ -2342,7 +2342,7 @@ static struct net_device_stats *igbvf_get_stats(struct net_device *netdev)
> > static int igbvf_change_mtu(struct net_device *netdev, int new_mtu)
> > {
> > struct igbvf_adapter *adapter = netdev_priv(netdev);
> > - int max_frame = new_mtu + ETH_HLEN + ETH_FCS_LEN;
> > + unsigned int max_frame = new_mtu + ETH_HLEN + ETH_FCS_LEN;
> >
> > if ((new_mtu < 68) || (max_frame > MAX_JUMBO_FRAME_SIZE)) {
> > dev_err(&adapter->pdev->dev, "Invalid MTU setting\n");
>
> It is safer to check:
> if ((new_mtu < 68) || (new_mtu > MAX_JUMBO_FRAME_SIZE - ETH_HLEN - ETH_FCS_LEN)) {
>
I believe my fix is already 100% safe... Where is the bug in my code?
Your fix harder to read because of the additional math and because it's
checking "new_mtu" when we care about "max_frame".
regards,
dan carpenter
------------------------------------------------------------------------------
How ServiceNow helps IT people transform IT departments:
1. Consolidate legacy IT systems to a single system of record for IT
2. Standardize and globalize service processes across IT
3. Implement zero-touch automation to replace manual, redundant tasks
http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [patch -stable] igbvf: integer wrapping bug setting the mtu
2013-09-13 9:54 ` Dan Carpenter
@ 2013-09-13 10:55 ` David Laight
2013-09-13 12:29 ` [patch v2 " Dan Carpenter
0 siblings, 1 reply; 6+ messages in thread
From: David Laight @ 2013-09-13 10:55 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jeff Kirsher, Jesse Brandeburg, Bruce Allan, Carolyn Wyborny,
Don Skidmore, Greg Rose, Peter P Waskiewicz Jr, Alex Duyck,
John Ronciak, Tushar Dave, David S. Miller, Mitch Williams,
Patrick McHardy, Greg Kroah-Hartman, e1000-devel, netdev,
kernel-janitors
> > > static int igbvf_change_mtu(struct net_device *netdev, int new_mtu)
> > > {
> > > struct igbvf_adapter *adapter = netdev_priv(netdev);
> > > - int max_frame = new_mtu + ETH_HLEN + ETH_FCS_LEN;
> > > + unsigned int max_frame = new_mtu + ETH_HLEN + ETH_FCS_LEN;
> > >
> > > if ((new_mtu < 68) || (max_frame > MAX_JUMBO_FRAME_SIZE)) {
> > > dev_err(&adapter->pdev->dev, "Invalid MTU setting\n");
> >
> > It is safer to check:
> > if ((new_mtu < 68) || (new_mtu > MAX_JUMBO_FRAME_SIZE - ETH_HLEN - ETH_FCS_LEN)) {
> >
>
> I believe my fix is already 100% safe... Where is the bug in my code?
>
> Your fix harder to read because of the additional math and because it's
> checking "new_mtu" when we care about "max_frame".
I don't like the window check on two variables.
However if ETH_HLEN and ETH_FCS_LEN are 'int' (not an unsigned type)
and 'new_mtu' is just below MAX_INT then the signed arithmetic
could overflow - generating an indeterminate value.
In which case 'max_frame' might not exceed MAX_JUMBO_FRAME_SIZE.
David
^ permalink raw reply [flat|nested] 6+ messages in thread* [patch v2 -stable] igbvf: integer wrapping bug setting the mtu
2013-09-13 10:55 ` David Laight
@ 2013-09-13 12:29 ` Dan Carpenter
2013-09-13 12:39 ` Jeff Kirsher
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2013-09-13 12:29 UTC (permalink / raw)
To: Jeff Kirsher
Cc: Jesse Brandeburg, Bruce Allan, Carolyn Wyborny, Don Skidmore,
Greg Rose, Peter P Waskiewicz Jr, Alex Duyck, John Ronciak,
Tushar Dave, David S. Miller, Mitch Williams, Patrick McHardy,
Greg Kroah-Hartman, e1000-devel, netdev, kernel-janitors
If new_mtu is very large then "new_mtu + ETH_HLEN + ETH_FCS_LEN" can
wrap and the check on the next line can underflow. This is one of those
bugs which can be triggered by the user if you have namespaces
configured.
Also since this is something the user can trigger then we don't want to
have dev_err() message.
This is a static checker fix and I'm not sure what the impact is.
---
v2: reformat and also remove the dev_err()
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c
index 95d5430..8cb7958 100644
--- a/drivers/net/ethernet/intel/igbvf/netdev.c
+++ b/drivers/net/ethernet/intel/igbvf/netdev.c
@@ -2344,10 +2344,9 @@ static int igbvf_change_mtu(struct net_device *netdev, int new_mtu)
struct igbvf_adapter *adapter = netdev_priv(netdev);
int max_frame = new_mtu + ETH_HLEN + ETH_FCS_LEN;
- if ((new_mtu < 68) || (max_frame > MAX_JUMBO_FRAME_SIZE)) {
- dev_err(&adapter->pdev->dev, "Invalid MTU setting\n");
+ if (new_mtu < 68 || new_mtu > INT_MAX - ETH_HLEN - ETH_FCS_LEN ||
+ max_frame > MAX_JUMBO_FRAME_SIZE)
return -EINVAL;
- }
#define MAX_STD_JUMBO_FRAME_SIZE 9234
if (max_frame > MAX_STD_JUMBO_FRAME_SIZE) {
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [patch v2 -stable] igbvf: integer wrapping bug setting the mtu
2013-09-13 12:29 ` [patch v2 " Dan Carpenter
@ 2013-09-13 12:39 ` Jeff Kirsher
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Kirsher @ 2013-09-13 12:39 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jesse Brandeburg, Bruce Allan, Carolyn Wyborny, Don Skidmore,
Greg Rose, Peter P Waskiewicz Jr, Alex Duyck, John Ronciak,
Tushar Dave, David S. Miller, Mitch Williams, Patrick McHardy,
Greg Kroah-Hartman, e1000-devel, netdev, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
On Fri, 2013-09-13 at 15:29 +0300, Dan Carpenter wrote:
> If new_mtu is very large then "new_mtu + ETH_HLEN + ETH_FCS_LEN" can
> wrap and the check on the next line can underflow. This is one of
> those
> bugs which can be triggered by the user if you have namespaces
> configured.
>
> Also since this is something the user can trigger then we don't want
> to
> have dev_err() message.
>
> This is a static checker fix and I'm not sure what the impact is.
> ---
> v2: reformat and also remove the dev_err()
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks Dan, I have added your patch to my queue.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-13 12:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-13 8:37 [patch -stable] igbvf: integer wrapping bug setting the mtu Dan Carpenter
2013-09-13 8:58 ` David Laight
2013-09-13 9:54 ` Dan Carpenter
2013-09-13 10:55 ` David Laight
2013-09-13 12:29 ` [patch v2 " Dan Carpenter
2013-09-13 12:39 ` Jeff Kirsher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).