From: Eric Dumazet <eric.dumazet@gmail.com>
To: Hong Zhiguo <honkiko@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, vyasevic@redhat.com,
Hong Zhiguo <zhiguohong@tencent.com>
Subject: Re: [PATCH net-next 1/2] bridge: use br_port_get_rtnl within rtnl lock
Date: Sat, 14 Sep 2013 11:46:58 -0700 [thread overview]
Message-ID: <1379184418.24408.45.camel@edumazet-glaptop> (raw)
In-Reply-To: <1379169748-767-2-git-send-email-zhiguohong@tencent.com>
On Sat, 2013-09-14 at 22:42 +0800, Hong Zhiguo wrote:
> From: Hong Zhiguo <zhiguohong@tencent.com>
>
> current br_port_get_rcu is problematic in bridging path
> (NULL deref). Change these calls in netlink path first.
>
> Signed-off-by: Hong Zhiguo <zhiguohong@tencent.com>
> ---
> net/bridge/br_netlink.c | 4 ++--
> net/bridge/br_private.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
Acked-by: Eric Dumazet <edumazet@google.com>
This is not net-next patch, but suitable for net tree, as the following
one fixes a potential panic.
next prev parent reply other threads:[~2013-09-14 18:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-14 14:42 [PATCH net-next 0/2] bridge: fix NULL pointer deref of br_port_get_rcu Hong Zhiguo
2013-09-14 14:42 ` [PATCH net-next 1/2] bridge: use br_port_get_rtnl within rtnl lock Hong Zhiguo
2013-09-14 18:46 ` Eric Dumazet [this message]
2013-09-14 14:42 ` [PATCH net-next 2/2] bridge: fix NULL pointer deref of br_port_get_rcu Hong Zhiguo
2013-09-14 18:47 ` Eric Dumazet
2013-09-16 17:58 ` Vlad Yasevich
2013-09-16 18:32 ` Stephen Hemminger
2013-09-16 18:37 ` Vlad Yasevich
2013-09-16 18:44 ` Stephen Hemminger
2013-09-16 4:55 ` [PATCH net-next 0/2] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379184418.24408.45.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=honkiko@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
--cc=zhiguohong@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox