netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH Resend 1/3] net: cdc-phonet: Staticize usbpn_probe
@ 2013-09-18  3:29 Sachin Kamat
  2013-09-18  3:30 ` [PATCH v2 2/3] net: bnx2x: Staticize local symbols Sachin Kamat
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Sachin Kamat @ 2013-09-18  3:29 UTC (permalink / raw)
  To: netdev; +Cc: davem, sachin.kamat, Rémi Denis-Courmont

'usbpn_probe' is referenced only in this file. Make it static.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Rémi Denis-Courmont <remi@remlab.net>
Cc: Rémi Denis-Courmont <remi@remlab.net>
---
 drivers/net/usb/cdc-phonet.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/usb/cdc-phonet.c b/drivers/net/usb/cdc-phonet.c
index 7d78669..8c44f86 100644
--- a/drivers/net/usb/cdc-phonet.c
+++ b/drivers/net/usb/cdc-phonet.c
@@ -328,7 +328,8 @@ MODULE_DEVICE_TABLE(usb, usbpn_ids);
 
 static struct usb_driver usbpn_driver;
 
-int usbpn_probe(struct usb_interface *intf, const struct usb_device_id *id)
+static int
+usbpn_probe(struct usb_interface *intf, const struct usb_device_id *id)
 {
 	static const char ifname[] = "usbpn%d";
 	const struct usb_cdc_union_desc *union_header = NULL;
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v2 2/3] net: bnx2x: Staticize local symbols
  2013-09-18  3:29 [PATCH Resend 1/3] net: cdc-phonet: Staticize usbpn_probe Sachin Kamat
@ 2013-09-18  3:30 ` Sachin Kamat
  2013-09-20 18:41   ` David Miller
  2013-09-18  3:30 ` [PATCH Resend 3/3] net: cxgb4vf: " Sachin Kamat
  2013-09-18 16:21 ` [PATCH Resend 1/3] net: cdc-phonet: Staticize usbpn_probe David Miller
  2 siblings, 1 reply; 7+ messages in thread
From: Sachin Kamat @ 2013-09-18  3:30 UTC (permalink / raw)
  To: netdev; +Cc: davem, sachin.kamat, Eilon Greenstein, Ariel Elior

Local symbols used only in this file are made static.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Eilon Greenstein <eilong@broadcom.com>
Cc: Ariel Elior <ariele@broadcom.com>
---
Changes since v1:
Changed the coding style as suggested by Ariel Elior.
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
index 2604b62..7991f10 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
@@ -2802,7 +2802,7 @@ struct set_vf_state_cookie {
 	u8 state;
 };
 
-void bnx2x_set_vf_state(void *cookie)
+static void bnx2x_set_vf_state(void *cookie)
 {
 	struct set_vf_state_cookie *p = (struct set_vf_state_cookie *)cookie;
 
@@ -3222,8 +3222,9 @@ void bnx2x_disable_sriov(struct bnx2x *bp)
 	pci_disable_sriov(bp->pdev);
 }
 
-int bnx2x_vf_ndo_prep(struct bnx2x *bp, int vfidx, struct bnx2x_virtf **vf,
-			struct pf_vf_bulletin_content **bulletin)
+static int bnx2x_vf_ndo_prep(struct bnx2x *bp, int vfidx,
+			     struct bnx2x_virtf **vf,
+			     struct pf_vf_bulletin_content **bulletin)
 {
 	if (bp->state != BNX2X_STATE_OPEN) {
 		BNX2X_ERR("vf ndo called though PF is down\n");
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH Resend 3/3] net: cxgb4vf: Staticize local symbols
  2013-09-18  3:29 [PATCH Resend 1/3] net: cdc-phonet: Staticize usbpn_probe Sachin Kamat
  2013-09-18  3:30 ` [PATCH v2 2/3] net: bnx2x: Staticize local symbols Sachin Kamat
@ 2013-09-18  3:30 ` Sachin Kamat
  2013-09-20 18:41   ` David Miller
  2013-09-18 16:21 ` [PATCH Resend 1/3] net: cdc-phonet: Staticize usbpn_probe David Miller
  2 siblings, 1 reply; 7+ messages in thread
From: Sachin Kamat @ 2013-09-18  3:30 UTC (permalink / raw)
  To: netdev; +Cc: davem, sachin.kamat, Casey Leedom

Local symbols used only in this file are made static.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Casey Leedom <leedom@chelsio.com>
---
 drivers/net/ethernet/chelsio/cxgb4vf/sge.c |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/sge.c b/drivers/net/ethernet/chelsio/cxgb4vf/sge.c
index df296af..8475c4c 100644
--- a/drivers/net/ethernet/chelsio/cxgb4vf/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb4vf/sge.c
@@ -1396,8 +1396,9 @@ static inline void copy_frags(struct sk_buff *skb,
  *	Builds an sk_buff from the given packet gather list.  Returns the
  *	sk_buff or %NULL if sk_buff allocation failed.
  */
-struct sk_buff *t4vf_pktgl_to_skb(const struct pkt_gl *gl,
-				  unsigned int skb_len, unsigned int pull_len)
+static struct sk_buff *t4vf_pktgl_to_skb(const struct pkt_gl *gl,
+					 unsigned int skb_len,
+					 unsigned int pull_len)
 {
 	struct sk_buff *skb;
 
@@ -1443,7 +1444,7 @@ out:
  *	Releases the pages of a packet gather list.  We do not own the last
  *	page on the list and do not free it.
  */
-void t4vf_pktgl_free(const struct pkt_gl *gl)
+static void t4vf_pktgl_free(const struct pkt_gl *gl)
 {
 	int frag;
 
@@ -1640,7 +1641,7 @@ static inline void rspq_next(struct sge_rspq *rspq)
  *	on this queue.  If the system is under memory shortage use a fairly
  *	long delay to help recovery.
  */
-int process_responses(struct sge_rspq *rspq, int budget)
+static int process_responses(struct sge_rspq *rspq, int budget)
 {
 	struct sge_eth_rxq *rxq = container_of(rspq, struct sge_eth_rxq, rspq);
 	int budget_left = budget;
@@ -1893,7 +1894,7 @@ static unsigned int process_intrq(struct adapter *adapter)
  * The MSI interrupt handler handles data events from SGE response queues as
  * well as error and other async events as they all use the same MSI vector.
  */
-irqreturn_t t4vf_intr_msi(int irq, void *cookie)
+static irqreturn_t t4vf_intr_msi(int irq, void *cookie)
 {
 	struct adapter *adapter = cookie;
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH Resend 1/3] net: cdc-phonet: Staticize usbpn_probe
  2013-09-18  3:29 [PATCH Resend 1/3] net: cdc-phonet: Staticize usbpn_probe Sachin Kamat
  2013-09-18  3:30 ` [PATCH v2 2/3] net: bnx2x: Staticize local symbols Sachin Kamat
  2013-09-18  3:30 ` [PATCH Resend 3/3] net: cxgb4vf: " Sachin Kamat
@ 2013-09-18 16:21 ` David Miller
  2013-09-19  6:44   ` Sachin Kamat
  2 siblings, 1 reply; 7+ messages in thread
From: David Miller @ 2013-09-18 16:21 UTC (permalink / raw)
  To: sachin.kamat; +Cc: netdev, remi

From: Sachin Kamat <sachin.kamat@linaro.org>
Date: Wed, 18 Sep 2013 08:59:59 +0530

> @@ -328,7 +328,8 @@ MODULE_DEVICE_TABLE(usb, usbpn_ids);
>  
>  static struct usb_driver usbpn_driver;
>  
> -int usbpn_probe(struct usb_interface *intf, const struct usb_device_id *id)
> +static int
> +usbpn_probe(struct usb_interface *intf, const struct usb_device_id *id)

Please keep it to one line, it's 82 columns which is fine.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH Resend 1/3] net: cdc-phonet: Staticize usbpn_probe
  2013-09-18 16:21 ` [PATCH Resend 1/3] net: cdc-phonet: Staticize usbpn_probe David Miller
@ 2013-09-19  6:44   ` Sachin Kamat
  0 siblings, 0 replies; 7+ messages in thread
From: Sachin Kamat @ 2013-09-19  6:44 UTC (permalink / raw)
  To: David Miller; +Cc: netdev@vger.kernel.org, remi

On 18 September 2013 21:51, David Miller <davem@davemloft.net> wrote:
> From: Sachin Kamat <sachin.kamat@linaro.org>
> Date: Wed, 18 Sep 2013 08:59:59 +0530
>
>> @@ -328,7 +328,8 @@ MODULE_DEVICE_TABLE(usb, usbpn_ids);
>>
>>  static struct usb_driver usbpn_driver;
>>
>> -int usbpn_probe(struct usb_interface *intf, const struct usb_device_id *id)
>> +static int
>> +usbpn_probe(struct usb_interface *intf, const struct usb_device_id *id)
>
> Please keep it to one line, it's 82 columns which is fine.

OK. Will re-send.

-- 
With warm regards,
Sachin

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 2/3] net: bnx2x: Staticize local symbols
  2013-09-18  3:30 ` [PATCH v2 2/3] net: bnx2x: Staticize local symbols Sachin Kamat
@ 2013-09-20 18:41   ` David Miller
  0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2013-09-20 18:41 UTC (permalink / raw)
  To: sachin.kamat; +Cc: netdev, eilong, ariele

From: Sachin Kamat <sachin.kamat@linaro.org>
Date: Wed, 18 Sep 2013 09:00:00 +0530

> Local symbols used only in this file are made static.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Eilon Greenstein <eilong@broadcom.com>
> Cc: Ariel Elior <ariele@broadcom.com>

Applied to net-next

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH Resend 3/3] net: cxgb4vf: Staticize local symbols
  2013-09-18  3:30 ` [PATCH Resend 3/3] net: cxgb4vf: " Sachin Kamat
@ 2013-09-20 18:41   ` David Miller
  0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2013-09-20 18:41 UTC (permalink / raw)
  To: sachin.kamat; +Cc: netdev, leedom

From: Sachin Kamat <sachin.kamat@linaro.org>
Date: Wed, 18 Sep 2013 09:00:01 +0530

> Local symbols used only in this file are made static.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Casey Leedom <leedom@chelsio.com>

Applied to net-next

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2013-09-20 18:41 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-18  3:29 [PATCH Resend 1/3] net: cdc-phonet: Staticize usbpn_probe Sachin Kamat
2013-09-18  3:30 ` [PATCH v2 2/3] net: bnx2x: Staticize local symbols Sachin Kamat
2013-09-20 18:41   ` David Miller
2013-09-18  3:30 ` [PATCH Resend 3/3] net: cxgb4vf: " Sachin Kamat
2013-09-20 18:41   ` David Miller
2013-09-18 16:21 ` [PATCH Resend 1/3] net: cdc-phonet: Staticize usbpn_probe David Miller
2013-09-19  6:44   ` Sachin Kamat

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).