Re: [RFC] b44: use phylib

[Joe Perches <joe@perches.com>]

On Sat, 2013-08-24 at 00:56 +0200, Hauke Mehrtens wrote:
> This splits the driver into the mac and a phy driver. On routers where
> this driver is used we have a switch which implements a phy and can be
> controlled by a phy driver.

One more trivial note:

> diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c
[]
> +static void b44_adjust_link(struct net_device *dev)
> +{
[]
> +	if (status_changed) {
> +		pr_info("%s: link %s", dev->name, phydev->link ?
> +			"UP" : "DOWN");
> +		if (phydev->link)
> +			pr_cont(" - %d/%s", phydev->speed,
> +			phydev->duplex == DUPLEX_FULL ? "full" : "half");
> +		pr_cont("\n");
> +	}

This bit would be better as:

	if (status_change) {
		if (phydev->link)
			netdev_info(dev, "link UP - %d/%s\n",
				    phydev->speed,
				    phydev->duplex == DUPLEX_FULL
				    ? "full" : "half");
		else
			netdev_info(dev, "link DOWN\n");
	}

so there's no possible interleaving by other
thread messages.