* [net-next] Fix hardcoded ni65 interrupt name to use system device value
@ 2013-09-21 19:32 Mark Repka
2013-09-21 19:48 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: Mark Repka @ 2013-09-21 19:32 UTC (permalink / raw)
To: netdev; +Cc: Mark Repka
The ni65 interrupt handler was using the hard-coded name which would make it difficult to tell where the interrupt came from. Changed to use the device name that made the interrupt.
Signed-off-by: Mark Repka <repkam09@gmail.com>
---
drivers/net/ethernet/amd/ni65.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/amd/ni65.c b/drivers/net/ethernet/amd/ni65.c
index 1cf33ad..00cb6db 100644
--- a/drivers/net/ethernet/amd/ni65.c
+++ b/drivers/net/ethernet/amd/ni65.c
@@ -295,7 +295,7 @@ static int ni65_open(struct net_device *dev)
{
struct priv *p = dev->ml_priv;
int irqval = request_irq(dev->irq, ni65_interrupt,0,
- cards[p->cardno].cardname,dev);
+ dev->name,dev);
if (irqval) {
printk(KERN_ERR "%s: unable to get IRQ %d (irqval=%d).\n",
dev->name,dev->irq, irqval);
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [net-next] Fix hardcoded ni65 interrupt name to use system device value
2013-09-21 19:32 [net-next] Fix hardcoded ni65 interrupt name to use system device value Mark Repka
@ 2013-09-21 19:48 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2013-09-21 19:48 UTC (permalink / raw)
To: Mark Repka; +Cc: netdev
Hello.
On 09/21/2013 11:32 PM, Mark Repka wrote:
> The ni65 interrupt handler was using the hard-coded name which would make it difficult to tell where the interrupt came from. Changed to use the device name that made the interrupt.
Please wrap your changelog lines at 80 columns (preferably even less).
> Signed-off-by: Mark Repka <repkam09@gmail.com>
> ---
> drivers/net/ethernet/amd/ni65.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/net/ethernet/amd/ni65.c b/drivers/net/ethernet/amd/ni65.c
> index 1cf33ad..00cb6db 100644
> --- a/drivers/net/ethernet/amd/ni65.c
> +++ b/drivers/net/ethernet/amd/ni65.c
> @@ -295,7 +295,7 @@ static int ni65_open(struct net_device *dev)
> {
> struct priv *p = dev->ml_priv;
> int irqval = request_irq(dev->irq, ni65_interrupt,0,
> - cards[p->cardno].cardname,dev);
> + dev->name,dev);
Don't indent with all spaces, use tabs at the start of line. And start the
line under 'dev->irq' please.
WBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-21 19:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-21 19:32 [net-next] Fix hardcoded ni65 interrupt name to use system device value Mark Repka
2013-09-21 19:48 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).