* [PATCH 2/2] drivers: net: vmxnet3 : vmxnet3_drv.c: removed checkaptch warning related to msleep()
@ 2013-09-22 16:09 Avinash kumar
2013-09-28 19:38 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Avinash kumar @ 2013-09-22 16:09 UTC (permalink / raw)
To: sbhatewara; +Cc: pv-drivers, netdev, linux-kernel, Avinash kumar
replaced msleep(1) by usleep_range(1000,1500). Documentation/timers/timers_howto.txt
suggests use of usleep_range() in place of msleep() where desired delay is of range
1-20 ms.
Signed-off-by: Avinash Kumar <avi.kp.137@gmail.com>
---
drivers/net/vmxnet3/vmxnet3_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index 7e2788c..34fd6b6 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -2608,7 +2608,7 @@ vmxnet3_close(struct net_device *netdev)
* completion.
*/
while (test_and_set_bit(VMXNET3_STATE_BIT_RESETTING, &adapter->state))
- msleep(1);
+ usleep_range(1000, 1500);
vmxnet3_quiesce_dev(adapter);
@@ -2656,7 +2656,7 @@ vmxnet3_change_mtu(struct net_device *netdev, int new_mtu)
* completion.
*/
while (test_and_set_bit(VMXNET3_STATE_BIT_RESETTING, &adapter->state))
- msleep(1);
+ usleep_range(1000, 1500);
if (netif_running(netdev)) {
vmxnet3_quiesce_dev(adapter);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] drivers: net: vmxnet3 : vmxnet3_drv.c: removed checkaptch warning related to msleep()
2013-09-22 16:09 [PATCH 2/2] drivers: net: vmxnet3 : vmxnet3_drv.c: removed checkaptch warning related to msleep() Avinash kumar
@ 2013-09-28 19:38 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-09-28 19:38 UTC (permalink / raw)
To: avi.kp.137; +Cc: sbhatewara, pv-drivers, netdev, linux-kernel
I see only patch #2 and #3.
Sort out why only 2 of the 3 patches were posted, and resend them
all.
Thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-28 19:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-22 16:09 [PATCH 2/2] drivers: net: vmxnet3 : vmxnet3_drv.c: removed checkaptch warning related to msleep() Avinash kumar
2013-09-28 19:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).