netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, Nicolas Dichtel <nicolas.dichtel@6wind.com>
Subject: [PATCH net-next] dev: advertise rx_flags changes
Date: Mon, 23 Sep 2013 16:25:34 +0200	[thread overview]
Message-ID: <1379946334-4183-1-git-send-email-nicolas.dichtel@6wind.com> (raw)

There is no netlink message/call to notifier chains when rx_flags are updated,
let's advertise everybody.

Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
 net/core/dev.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 5c713f2239cc..6c91d3919279 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -4818,8 +4818,13 @@ static void dev_change_rx_flags(struct net_device *dev, int flags)
 {
 	const struct net_device_ops *ops = dev->netdev_ops;
 
-	if ((dev->flags & IFF_UP) && ops->ndo_change_rx_flags)
-		ops->ndo_change_rx_flags(dev, flags);
+	if (dev->flags & IFF_UP) {
+		if (ops->ndo_change_rx_flags)
+			ops->ndo_change_rx_flags(dev, flags);
+
+		call_netdevice_notifiers(NETDEV_CHANGE, dev);
+		rtmsg_ifinfo(RTM_NEWLINK, dev, flags);
+	}
 }
 
 static int __dev_set_promiscuity(struct net_device *dev, int inc)
-- 
1.8.2.1

             reply	other threads:[~2013-09-23 14:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-23 14:25 Nicolas Dichtel [this message]
2013-09-23 19:27 ` [PATCH net-next] dev: advertise rx_flags changes Stephen Hemminger
2013-09-24 16:21   ` [PATCH net-next v2] dev: always " Nicolas Dichtel
2013-09-24 16:47     ` Stephen Hemminger
2013-09-25 10:02       ` [PATCH net-next v3 1/2] dev: update __dev_notify_flags() to send rtnl msg Nicolas Dichtel
2013-09-25 10:02         ` [PATCH net-next v3 2/2] dev: always advertise rx_flags changes via netlink Nicolas Dichtel
2013-09-30 19:08           ` David Miller
2013-09-30 19:08         ` [PATCH net-next v3 1/2] dev: update __dev_notify_flags() to send rtnl msg David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379946334-4183-1-git-send-email-nicolas.dichtel@6wind.com \
    --to=nicolas.dichtel@6wind.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).