From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Templin, Fred L" <Fred.L.Templin@boeing.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: missing kfree_skb(skb) in ipv6_frag_rcv()?
Date: Mon, 23 Sep 2013 11:37:11 -0700 [thread overview]
Message-ID: <1379961431.3165.25.camel@edumazet-glaptop> (raw)
In-Reply-To: <2134F8430051B64F815C691A62D983181101B8@XCH-BLV-504.nw.nos.boeing.com>
On Mon, 2013-09-23 at 17:42 +0000, Templin, Fred L wrote:
> Hello,
>
> In the most recent kernel releases, in ./net/ipv6/reassembly.c,
> I see the following code at the end of "ipv6_frag_rcv()":
>
> + IP6_INC_STATS_BH(net, ip6_dst_idev(skb_dst(skb)), IPSTATS_MIB_REASMFAILS);
> + kfree_skb(skb);
> + return -1;
> +
> +fail_hdr:
> + IP6_INC_STATS(net, ip6_dst_idev(skb_dst(skb)), IPSTATS_MIB_INHDRERRORS);
> + icmpv6_param_prob(skb, ICMPV6_HDR_FIELD, skb_network_header_len(skb));
> + return -1;
> +}
>
> Perhaps I missed it, but I did not find anywhere that 'icmpv6_param_prob()'
> frees the skb, and hence it appears that there is a missing kfree_skb()
> in the above code. Is this a bug?
void icmpv6_param_prob(struct sk_buff *skb, u8 code, int pos)
{
icmp6_send(skb, ICMPV6_PARAMPROB, code, pos);
kfree_skb(skb);
}
Well, I do see kfree_skb(skb) here.
next prev parent reply other threads:[~2013-09-23 18:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 16:04 [PATCH ethtool] sfc: Add support for EF10 registers Ben Hutchings
2013-09-23 16:14 ` David Laight
2013-09-23 16:52 ` Ben Hutchings
2013-09-23 17:42 ` missing kfree_skb(skb) in ipv6_frag_rcv()? Templin, Fred L
2013-09-23 18:37 ` Eric Dumazet [this message]
2013-09-23 19:32 ` Templin, Fred L
2013-10-01 15:36 ` [PATCH ethtool] sfc: Add support for EF10 registers Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379961431.3165.25.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=Fred.L.Templin@boeing.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox