From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>
Subject: Re: BUG: 32 bit net stats
Date: Mon, 23 Sep 2013 15:04:29 -0700 [thread overview]
Message-ID: <1379973869.3165.27.camel@edumazet-glaptop> (raw)
In-Reply-To: <5240B771.8040307@mojatatu.com>
On Mon, 2013-09-23 at 17:49 -0400, Jamal Hadi Salim wrote:
> Something broke in sending of 32 bit version of netstat around the
> time 64 bit version was improved. I went back as far as 3.8.0 to recent
> kernels. Could have been earlier.
> The work around in user space is when you see 64 bit stats just ignore
> the 32 bit version (which iproute2 does and so am i;->).
>
> But assumming there are tools out there that know only of 32 bit
> variant they will get bad stats. Here's a compile tested only patch.
> Wont have to test anything for at least another day.
>
> cheers,
> jamal
>
Hi Jamal
Sorry, this doesnt make sense to me.
Existing code seems to be fine.
Which driver do you use ?
next prev parent reply other threads:[~2013-09-23 22:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 21:49 BUG: 32 bit net stats Jamal Hadi Salim
2013-09-23 22:04 ` Eric Dumazet [this message]
2013-09-23 22:15 ` Jamal Hadi Salim
2013-09-23 22:42 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379973869.3165.27.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox