From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Joe Perches <joe@perches.com>
Cc: Don, e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
Bruce Allan <bruce.w.allan@intel.com>,
Brandeburg <jesse.brandeburg@intel.com>,
John Ronciak <john.ronciak@intel.com>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, Jesse
Subject: Re: [PATCH 02/10] intel: Remove extern from function prototypes
Date: Tue, 24 Sep 2013 15:07:29 -0700 [thread overview]
Message-ID: <1380060449.2189.6.camel@jtkirshe-mobl> (raw)
In-Reply-To: <5ccc921af41a862fe969809228f029035f851502.1380056108.git.joe@perches.com>
[-- Attachment #1.1: Type: text/plain, Size: 596 bytes --]
On Tue, 2013-09-24 at 14:09 -0700, Joe Perches wrote:
> There are a mix of function prototypes with and without extern
> in the kernel sources. Standardize on not using extern for
> function prototypes.
>
> Function prototypes don't need to be written with extern.
> extern is assumed by the compiler. Its use is as unnecessary as
> using auto to declare automatic/local variables in a block.
So you are able to confirm that all compilers make this assumption
correctly? The initial reason for using extern was because not all
compilers made the assumption or made it correctly.
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 416 bytes --]
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
[-- Attachment #3: Type: text/plain, Size: 257 bytes --]
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
next prev parent reply other threads:[~2013-09-24 22:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 21:09 [PATCH 00/10 - GIT PULL] drivers: net: Next block of Remove extern from function prototypes Joe Perches
2013-09-24 21:09 ` [PATCH 01/10] ibm/emac: " Joe Perches
2013-09-24 21:09 ` [PATCH 02/10] intel: " Joe Perches
2013-09-24 22:07 ` Jeff Kirsher [this message]
2013-09-24 22:16 ` Ben Hutchings
2013-09-25 1:34 ` David Miller
2013-09-24 22:22 ` Joe Perches
2013-09-24 21:09 ` [PATCH 03/10] oki-semi: " Joe Perches
2013-09-24 21:09 ` [PATCH 04/10] qlogic: " Joe Perches
2013-09-24 21:09 ` [PATCH 05/10] sfc: " Joe Perches
2013-09-24 21:10 ` [PATCH 06/10] stmicro: " Joe Perches
2013-09-24 21:10 ` [PATCH 07/10] ti: " Joe Perches
2013-09-24 21:10 ` [PATCH 08/10] toshiba: " Joe Perches
2013-09-24 21:26 ` Geoff Levand
2013-09-24 21:10 ` [PATCH 09/10] fddi/skfp: " Joe Perches
2013-09-24 21:10 ` [PATCH 10/10] irda: " Joe Perches
2013-09-25 19:04 ` [PATCH 00/10 - GIT PULL] drivers: net: Next block of " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380060449.2189.6.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jesse.brandeburg@intel.com \
--cc=joe@perches.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).