From: Eric Dumazet <eric.dumazet@gmail.com>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net 1/2] ip_tunnel: Fix a memory corruption in ip_tunnel_xmit
Date: Wed, 25 Sep 2013 05:44:25 -0700 [thread overview]
Message-ID: <1380113065.3165.146.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130925121337.GZ7660@secunet.com>
On Wed, 2013-09-25 at 14:13 +0200, Steffen Klassert wrote:
> It was commit c544193214 (GRE: Refactor GRE tunneling code.)
> when net/ipv4/ip_tunnel.c was created.
Yeah. This one begins to be very upsetting.
>
> >
> > (commit id and title in your changelog would be really nice)
> >
>
> I can send a v2 with these informations included if you want
> that.
I think that patches coming from experimented kernel developers
should always include a study of bug origin.
Otherwise, both maintainer and stable teams have to figure it, and
they sometime lack the time or context.
Plus it's good to CC patch author and reviewers so that he can learn of
its mistakes, and Ack your work as well.
Thanks
next prev parent reply other threads:[~2013-09-25 12:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 5:54 [PATCH net 1/2] ip_tunnel: Fix a memory corruption in ip_tunnel_xmit Steffen Klassert
2013-09-25 5:55 ` [PATCH net 2/2] ip_tunnel: Add fallback tunnels to the hash lists Steffen Klassert
2013-09-25 16:03 ` Pravin Shelar
2013-09-26 8:13 ` Steffen Klassert
2013-09-26 18:24 ` Pravin Shelar
2013-09-27 7:56 ` Steffen Klassert
2013-09-28 2:40 ` Pravin Shelar
2013-09-25 11:56 ` [PATCH net 1/2] ip_tunnel: Fix a memory corruption in ip_tunnel_xmit Eric Dumazet
2013-09-25 12:13 ` Steffen Klassert
2013-09-25 12:44 ` Eric Dumazet [this message]
2013-09-25 16:55 ` Pravin Shelar
2013-09-26 8:25 ` Steffen Klassert
2013-09-26 18:25 ` Pravin Shelar
2013-09-27 7:45 ` Steffen Klassert
2013-09-28 2:34 ` Pravin Shelar
2013-09-30 18:40 ` David Miller
2013-10-01 5:15 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380113065.3165.146.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox