From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH tip/core/rcu 04/13] wireless: Apply rcu_access_pointer() to avoid sparse false positive Date: Wed, 25 Sep 2013 18:48:23 +0100 Message-ID: <1380131303.2222.9.camel@bwh-desktop.uk.level5networks.com> References: <20130925013451.GA31260@linux.vnet.ibm.com> <1380072916-31557-1-git-send-email-paulmck@linux.vnet.ibm.com> <1380072916-31557-4-git-send-email-paulmck@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Stephen Hemminger , tglx@linutronix.de, laijs@cn.fujitsu.com, edumazet@google.com, "David S. Miller" , peterz@infradead.org, fweisbec@gmail.com, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, josh@joshtriplett.org, dhowells@redhat.com, sbw@mit.edu, niv@us.ibm.com, netdev@vger.kernel.org, mathieu.desnoyers@efficios.com, dipankar@in.ibm.com, darren@dvhart.com, akpm@linux-foundation.org, mingo@kernel.org To: "Paul E. McKenney" Return-path: In-Reply-To: <1380072916-31557-4-git-send-email-paulmck@linux.vnet.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On Tue, 2013-09-24 at 18:35 -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > The sparse checking for rcu_assign_pointer() was recently upgraded > to reject non-__kernel address spaces. This also rejects __rcu, > which is almost always the right thing to do. However, the uses in > cfg80211_combine_bsses() and cfg80211_bss_update() are legitimate: > They is assigning a pointer to an element from an RCU-protected list, [...] 'They is'? This error is also in the commit messsages for the bridge and mac80211 patches, and maybe others that weren't sent to netdev. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.