From: Eric Dumazet <eric.dumazet@gmail.com>
To: Nikolay Aleksandrov <nikolay@redhat.com>
Cc: Daniel Borkmann <dborkman@redhat.com>,
netdev@vger.kernel.org, davem@davemloft.net, andy@greyhouse.net,
fubar@us.ibm.com, vfalico@redhat.com
Subject: Re: [PATCH]
Date: Thu, 26 Sep 2013 08:53:19 -0700 [thread overview]
Message-ID: <1380210799.3165.187.camel@edumazet-glaptop> (raw)
In-Reply-To: <52445553.1030308@redhat.com>
On Thu, 2013-09-26 at 17:40 +0200, Nikolay Aleksandrov wrote:
> >
> 1 question, I might be missing something but proto_ports_offset() gets the SPI
> with that 4 byte offset as is written in the comments, in every other case
> proto_ports_offset() is 0, so why would we want the SPI in the ->ports field ?
> And even then isn't it supposed to be 16 bits (2 bytes) and not 4, since we need
> to pass over "next header" (8 bits) and length (8 bits) ?
struct ip_auth_hdr {
__u8 nexthdr;
__u8 hdrlen; /* This one is measured in 32 bit units! */
__be16 reserved;
__be32 spi;
__be32 seq_no; /* Sequence number */
__u8 auth_data[0]; /* Variable len but >=4. Mind the 64 bit alignment! */
};
offsetof(spi, struct ...) = 4
next prev parent reply other threads:[~2013-09-26 15:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 14:09 [PATCH net-next v3 0/3] bonding: modify the current and add new hash functions Nikolay Aleksandrov
2013-09-26 14:09 ` [PATCH net-next v3 1/3] flow_dissector: factor out the ports extraction in skb_flow_get_ports Nikolay Aleksandrov
2013-09-26 14:36 ` Veaceslav Falico
2013-09-26 15:27 ` [PATCH] Eric Dumazet
2013-09-26 15:40 ` [PATCH] Nikolay Aleksandrov
2013-09-26 15:44 ` [PATCH] Nikolay Aleksandrov
2013-09-26 15:53 ` Eric Dumazet [this message]
2013-09-26 15:44 ` [PATCH] net: flow_dissector: fix thoff for IPPROTO_AH Eric Dumazet
2013-09-26 15:48 ` Nikolay Aleksandrov
2013-09-26 16:05 ` Eric Dumazet
2013-09-26 16:03 ` Nikolay Aleksandrov
2013-09-26 16:03 ` Daniel Borkmann
2013-09-30 19:34 ` David Miller
2013-09-26 14:09 ` [PATCH net-next v3 2/3] bonding: modify the old and add new xmit hash policies Nikolay Aleksandrov
2013-09-26 14:34 ` Veaceslav Falico
2013-09-26 16:02 ` Eric Dumazet
2013-09-26 14:09 ` [PATCH net-next v3 3/3] bonding: document the new xmit policy modes and update the changed ones Nikolay Aleksandrov
-- strict thread matches above, loose matches on Subject: below --
2003-12-27 13:50 [PATCH] Bart De Schuymer
2003-11-13 0:39 [PATCH] Stephen Hemminger
2003-07-08 22:16 [PATCH] Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380210799.3165.187.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox