From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
Kalle Valo <kvalo@qca.qualcomm.com>,
netdev <netdev@vger.kernel.org>,
ath10k@lists.infradead.org
Subject: Re: [PATCH net-next] net:drivers/net: Miscellaneous conversions to ETH_ALEN
Date: Wed, 02 Oct 2013 20:31:50 -0700 [thread overview]
Message-ID: <1380771110.2081.89.camel@joe-AO722> (raw)
In-Reply-To: <1380760114.2081.81.camel@joe-AO722>
On Wed, 2013-10-02 at 17:28 -0700, Joe Perches wrote:
> On Wed, 2013-10-02 at 17:09 -0700, Joe Perches wrote:
> > This has been running a _long_ time (broken?) on
> > drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> >
> > $ spatch --version
> > spatch version 1.0.0-rc14 without Python support and with PCRE support
>
> Nope. Not hung/broken. Just a _long_ time to run.
>
> HANDLING: drivers/net/ethernet/mellanox/mlx4/en_rx.c
> HANDLING: drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> Note: processing took 2299.7s: drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> HANDLING: drivers/net/ethernet/mellanox/mlx4/port.c
Hi again Julia:
Oddly, just a few files took > 1000 seconds to run.
Most all the rest were < 10 seconds (no report).
A few were ~100 seconds.
HANDLING: drivers/net/ethernet/mellanox/mlx4/en_netdev.c
Note: processing took 2299.7s: drivers/net/ethernet/mellanox/mlx4/en_netdev.c
[]
HANDLING: drivers/net/wireless/ipw2x00/libipw_rx.c
Note: processing took 5308.0s: drivers/net/wireless/ipw2x00/libipw_rx.c
[]
HANDLING: drivers/net/wireless/hostap/hostap_80211_rx.c
Note: processing took 1336.6s: drivers/net/wireless/hostap/hostap_80211_rx.c
I don't know what causes the delays on these files.
The only output I get for net-next is:
* TODO
[[view:drivers/net/wireless/zd1201.c::face=ovl-face1::linb=331::colb=3::cole=9][ drivers/net/wireless/zd1201.c::331]]
* TODO
[[view:drivers/net/wireless/zd1201.c::face=ovl-face1::linb=332::colb=3::cole=9][ drivers/net/wireless/zd1201.c::332]]
* TODO
[[view:drivers/net/wireless/zd1201.c::face=ovl-face1::linb=332::colb=3::cole=9][ drivers/net/wireless/zd1201.c::332]]
* TODO
[[view:drivers/net/wireless/zd1201.c::face=ovl-face1::linb=332::colb=3::cole=9][ drivers/net/wireless/zd1201.c::332]]
* TODO
[[view:drivers/net/wireless/zd1201.c::face=ovl-face1::linb=333::colb=3::cole=9][ drivers/net/wireless/zd1201.c::333]]
* TODO
[[view:drivers/net/wireless/ath/ath10k/wmi.c::face=ovl-face1::linb=1761::colb=1::cole=7][ drivers/net/wireless/ath/ath10k/wmi.c::1761]]
and the zd1201 conversions would be kind of odd.
Anyway, the ath10k file is a good one to patch. Thanks.
I'll send a patch separately.
next prev parent reply other threads:[~2013-10-03 3:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 2:04 [PATCH net-next] net:drivers/net: Miscellaneous conversions to ETH_ALEN Joe Perches
[not found] ` <87k3hw469z.fsf@kamboji.qca.qualcomm.com>
2013-10-02 6:40 ` Joe Perches
2013-10-02 17:44 ` Luis R. Rodriguez
2013-10-02 18:02 ` Joe Perches
2013-10-02 22:38 ` Julia Lawall
2013-10-03 0:09 ` Joe Perches
2013-10-03 0:28 ` Joe Perches
2013-10-03 3:31 ` Joe Perches [this message]
2013-10-03 3:39 ` [PATCH net-next] ath10k: wmi: Convert use of 6 " Joe Perches
2013-10-03 3:44 ` David Miller
2013-10-03 4:18 ` Eric Dumazet
2013-10-03 4:34 ` Kalle Valo
2013-10-03 4:44 ` Eric Dumazet
2013-10-03 4:54 ` Kalle Valo
2013-10-03 5:09 ` Joe Perches
2013-10-03 5:24 ` Eric Dumazet
2013-10-03 5:34 ` Joe Perches
2013-10-03 5:47 ` Julia Lawall
2013-10-03 6:00 ` Eric Dumazet
2013-10-03 6:07 ` Joe Perches
2013-10-03 6:32 ` Julia Lawall
2013-10-03 4:56 ` Joe Perches
2013-10-03 5:43 ` Julia Lawall
2013-10-03 5:41 ` [PATCH net-next] net:drivers/net: Miscellaneous conversions " Julia Lawall
2013-10-02 7:27 ` Arend van Spriel
2013-10-02 21:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380771110.2081.89.camel@joe-AO722 \
--to=joe@perches.com \
--cc=ath10k@lists.infradead.org \
--cc=julia.lawall@lip6.fr \
--cc=kvalo@qca.qualcomm.com \
--cc=mcgrof@do-not-panic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox