From: djduanjiong@gmail.com
To: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>,
"David S. Miller" <davem@davemloft.net>,
linux-wimax@intel.com
Cc: wimax@linuxwimax.org, netdev@vger.kernel.org,
Duan Jiong <duanj.fnst@cn.fujitsu.com>
Subject: [PATCH] wimax: Use WARN(1,...) rather than printk followed by WARN_ON(1)
Date: Mon, 7 Oct 2013 17:30:38 -0700 [thread overview]
Message-ID: <1381192238-6486-1-git-send-email-duanj.fnst@cn.fujitsu.com> (raw)
From: Duan Jiong <duanj.fnst@cn.fujitsu.com>
Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
---
net/wimax/id-table.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/net/wimax/id-table.c b/net/wimax/id-table.c
index 72273ab..635a4d2 100644
--- a/net/wimax/id-table.c
+++ b/net/wimax/id-table.c
@@ -136,10 +136,8 @@ void wimax_id_table_release(void)
return;
#endif
spin_lock(&wimax_id_table_lock);
- list_for_each_entry(wimax_dev, &wimax_id_table, id_table_node) {
- printk(KERN_ERR "BUG: %s wimax_dev %p ifindex %d not cleared\n",
+ list_for_each_entry(wimax_dev, &wimax_id_table, id_table_node)
+ WARN(1, KERN_ERR "BUG: %s wimax_dev %p ifindex %d not cleared\n",
__func__, wimax_dev, wimax_dev->net_dev->ifindex);
- WARN_ON(1);
- }
spin_unlock(&wimax_id_table_lock);
}
--
1.7.7.6
next reply other threads:[~2013-10-07 16:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 0:30 djduanjiong [this message]
2013-10-11 18:38 ` [PATCH] wimax: Use WARN(1,...) rather than printk followed by WARN_ON(1) David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381192238-6486-1-git-send-email-duanj.fnst@cn.fujitsu.com \
--to=djduanjiong@gmail.com \
--cc=davem@davemloft.net \
--cc=duanj.fnst@cn.fujitsu.com \
--cc=inaky.perez-gonzalez@intel.com \
--cc=linux-wimax@intel.com \
--cc=netdev@vger.kernel.org \
--cc=wimax@linuxwimax.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).