* [PATCH net-next] fib_trie: only calc for the un-first node
@ 2013-10-08 3:36 baker.kernel
2013-10-10 4:17 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: baker.kernel @ 2013-10-08 3:36 UTC (permalink / raw)
To: davem, kuznet, jmorris, yoshfuji, kaber, netdev, linux-kernel; +Cc: baker.zhang
From: "baker.zhang" <baker.kernel@gmail.com>
This is a enhancement.
for the first node in fib_trie, newpos is 0, bit is 1.
Only for the leaf or node with unmatched key need calc pos.
Signed-off-by: baker.zhang <baker.kernel@gmail.com>
---
net/ipv4/fib_trie.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
index 45c74ba..ec9a9ef 100644
--- a/net/ipv4/fib_trie.c
+++ b/net/ipv4/fib_trie.c
@@ -1117,12 +1117,8 @@ static struct list_head *fib_insert_node(struct trie *t, u32 key, int plen)
* first tnode need some special handling
*/
- if (tp)
- pos = tp->pos+tp->bits;
- else
- pos = 0;
-
if (n) {
+ pos = tp ? tp->pos+tp->bits : 0;
newpos = tkey_mismatch(key, pos, n->key);
tn = tnode_new(n->key, newpos, 1);
} else {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] fib_trie: only calc for the un-first node
2013-10-08 3:36 [PATCH net-next] fib_trie: only calc for the un-first node baker.kernel
@ 2013-10-10 4:17 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-10-10 4:17 UTC (permalink / raw)
To: baker.kernel; +Cc: kuznet, jmorris, yoshfuji, kaber, netdev, linux-kernel
From: baker.kernel@gmail.com
Date: Tue, 8 Oct 2013 11:36:51 +0800
> From: "baker.zhang" <baker.kernel@gmail.com>
>
> This is a enhancement.
>
> for the first node in fib_trie, newpos is 0, bit is 1.
> Only for the leaf or node with unmatched key need calc pos.
>
> Signed-off-by: baker.zhang <baker.kernel@gmail.com>
The compiler is probably doing this transformation all by itself,
but applied anyways, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-10 4:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-08 3:36 [PATCH net-next] fib_trie: only calc for the un-first node baker.kernel
2013-10-10 4:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).