From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Yasevich Subject: [PATCH v4 net 2/3] sctp: Use software crc32 checksum when xfrm transform will happen. Date: Tue, 15 Oct 2013 22:01:30 -0400 Message-ID: <1381888891-31186-3-git-send-email-vyasevich@gmail.com> References: <1381888891-31186-1-git-send-email-vyasevich@gmail.com> Cc: linux-sctp@vger.kernel.org, fan.du@windriver.com, Neil Horman , Steffen Klassert , Vlad Yasevich To: netdev@vger.kernel.org Return-path: Received: from mail-qc0-f172.google.com ([209.85.216.172]:54783 "EHLO mail-qc0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932759Ab3JPCCF (ORCPT ); Tue, 15 Oct 2013 22:02:05 -0400 In-Reply-To: <1381888891-31186-1-git-send-email-vyasevich@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Fan Du igb/ixgbe have hardware sctp checksum support, when this feature is enabled and also IPsec is armed to protect sctp traffic, ugly things happened as xfrm_output checks CHECKSUM_PARTIAL to do checksum operation(sum every thing up and pack the 16bits result in the checksum field). The result is fail establishment of sctp communication. Cc: Neil Horman Cc: Steffen Klassert Signed-off-by: Fan Du Signed-off-by: Vlad Yasevich --- net/sctp/output.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/sctp/output.c b/net/sctp/output.c index 0ac3a65..d35b54c 100644 --- a/net/sctp/output.c +++ b/net/sctp/output.c @@ -536,7 +536,8 @@ int sctp_packet_transmit(struct sctp_packet *packet) * by CRC32-C as described in . */ if (!sctp_checksum_disable) { - if (!(dst->dev->features & NETIF_F_SCTP_CSUM)) { + if (!(dst->dev->features & NETIF_F_SCTP_CSUM) || + (dst_xfrm(dst) != NULL)) { __u32 crc32 = sctp_start_cksum((__u8 *)sh, cksum_buf_len); /* 3) Put the resultant value into the checksum field in the -- 1.8.3.1