From: Vlad Yasevich <vyasevich@gmail.com>
To: netdev@vger.kernel.org
Cc: linux-sctp@vger.kernel.org, fan.du@windriver.com,
Vlad Yasevich <vyasevich@gmail.com>
Subject: [PATCH v4 net 3/3] sctp: Perform software checksum if packet has to be fragmented.
Date: Tue, 15 Oct 2013 22:01:31 -0400 [thread overview]
Message-ID: <1381888891-31186-4-git-send-email-vyasevich@gmail.com> (raw)
In-Reply-To: <1381888891-31186-1-git-send-email-vyasevich@gmail.com>
IP/IPv6 fragmentation knows how to compute only TCP/UDP checksum.
This causes problems if SCTP packets has to be fragmented and
ipsummed has been set to PARTIAL due to checksum offload support.
This condition can happen when retransmitting after MTU discover,
or when INIT or other control chunks are larger then MTU.
Check for the rare fragmentation condition in SCTP and use software
checksum calculation in this case.
CC: Fan Du <fan.du@windriver.com>
Signed-off-by: Vlad Yasevich <vyasevich@gmail.com>
---
net/sctp/output.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sctp/output.c b/net/sctp/output.c
index d35b54c..3191373 100644
--- a/net/sctp/output.c
+++ b/net/sctp/output.c
@@ -537,7 +537,7 @@ int sctp_packet_transmit(struct sctp_packet *packet)
*/
if (!sctp_checksum_disable) {
if (!(dst->dev->features & NETIF_F_SCTP_CSUM) ||
- (dst_xfrm(dst) != NULL)) {
+ (dst_xfrm(dst) != NULL) || packet->ipfragok) {
__u32 crc32 = sctp_start_cksum((__u8 *)sh, cksum_buf_len);
/* 3) Put the resultant value into the checksum field in the
--
1.8.3.1
next prev parent reply other threads:[~2013-10-16 2:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 2:01 [PATCH v4 net 0/3] sctp: Use software checksum under certain Vlad Yasevich
2013-10-16 2:01 ` [PATCH v4 net 1/3] net: dst: provide accessor function to dst->xfrm Vlad Yasevich
2013-10-16 13:31 ` Neil Horman
2013-10-16 2:01 ` [PATCH v4 net 2/3] sctp: Use software crc32 checksum when xfrm transform will happen Vlad Yasevich
2013-10-16 13:32 ` Neil Horman
2013-10-16 2:01 ` Vlad Yasevich [this message]
2013-10-16 13:34 ` [PATCH v4 net 3/3] sctp: Perform software checksum if packet has to be fragmented Neil Horman
2013-10-16 8:02 ` [PATCH v4 net 0/3] sctp: Use software checksum under certain Daniel Borkmann
2013-10-17 19:26 ` David Miller
2013-10-17 20:21 ` Vlad Yasevich
2013-10-18 3:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381888891-31186-4-git-send-email-vyasevich@gmail.com \
--to=vyasevich@gmail.com \
--cc=fan.du@windriver.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).