From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: David Miller <davem@davemloft.net>
Cc: sergei.shtylyov@cogentembedded.com, a@vger.kernel.org,
shannon.nelson@intel.com, netdev@vger.kernel.org,
gospo@redhat.com, sassmann@redhat.com,
jesse.brandeburg@intel.com
Subject: Re: [net-next 11/14] i40e: reorder block declarations in debugfs
Date: Fri, 18 Oct 2013 10:42:50 -0700 [thread overview]
Message-ID: <1382118170.2034.21.camel@jtkirshe-mobl> (raw)
In-Reply-To: <20131018.133810.644337234048520007.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
On Fri, 2013-10-18 at 13:38 -0400, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Fri, 18 Oct 2013 07:34:52 -0700
>
> > On Fri, 2013-10-18 at 18:13 +0400, Sergei Shtylyov wrote:
> >> On 18-10-2013 17:23, Jeff Kirsher wrote:
> >>
> >> > From: Shannon Nelson <shannon.nelson@intel.com>
> >>
> >> > This is a cleanup of the arguments declared at the beginning
> >> > of each function.
> >>
> >> I hope you meant "local variables" because "arguments" are the
> >> values
> >> passed to a function.
> >
> > Yes, he meant local variables.
>
> There is probably going to be some other feedback to address, so please
> fix this commit message when you respin this series.
>
> Thanks Jeff.
Ok, I will wait for additional feedback before re-sending the series. I
do not want to waste your time and mine re-spinning the series if there
is additional feedback.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-10-18 17:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 13:23 [net-next 00/14][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2013-10-18 13:23 ` [net-next 01/14] i40e: do not flush after re-enabling interrupts Jeff Kirsher
2013-10-18 13:23 ` [net-next 02/14] i40e: don't free nonexistent rings Jeff Kirsher
2013-10-18 13:23 ` [net-next 03/14] i40e: assign correct vector to VF Jeff Kirsher
2013-10-18 14:08 ` Sergei Shtylyov
2013-10-18 13:23 ` [net-next 04/14] i40e: fixup legacy interrupt handling Jeff Kirsher
2013-10-18 13:23 ` [net-next 05/14] i40e: debugfs fixups Jeff Kirsher
2013-10-18 13:23 ` [net-next 06/14] i40e: clamp debugfs nvm read command Jeff Kirsher
2013-10-18 13:23 ` [net-next 07/14] i40e: fix use of untrusted scalar value warning Jeff Kirsher
2013-10-18 13:23 ` [net-next 08/14] i40e: fix sign extension issue Jeff Kirsher
2013-10-18 13:23 ` [net-next 09/14] i40e: refactor fdir setup function Jeff Kirsher
2013-10-18 13:23 ` [net-next 10/14] i40e: tweaking icr0 handling for legacy irq Jeff Kirsher
2013-10-18 13:23 ` [net-next 11/14] i40e: reorder block declarations in debugfs Jeff Kirsher
2013-10-18 14:13 ` Sergei Shtylyov
2013-10-18 14:34 ` Jeff Kirsher
2013-10-18 17:38 ` David Miller
2013-10-18 17:42 ` Jeff Kirsher [this message]
2013-10-18 13:23 ` [net-next 12/14] i40e: check vsi ptrs before dumping them Jeff Kirsher
2013-10-18 13:23 ` [net-next 13/14] i40e: use pf_id for pf function id in qtx_ctl Jeff Kirsher
2013-10-18 13:23 ` [net-next 14/14] i40e: Bump version Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382118170.2034.21.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=a@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=shannon.nelson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).