From: "Yuval Mintz" <yuvalmin@broadcom.com>
To: davem@davemloft.net, netdev@vger.kernel.org
Cc: ariele@broadcom.com, eilong@broadcom.com,
"Dmitry Kravkov" <dmitry@broadcom.com>,
"Yuval Mintz" <yuvalmin@broadcom.com>
Subject: [PATCH net v2 4/9] bnx2x: Fix Coalescing configuration
Date: Sun, 20 Oct 2013 16:51:29 +0200 [thread overview]
Message-ID: <1382280694-8428-5-git-send-email-yuvalmin@broadcom.com> (raw)
In-Reply-To: <1382280694-8428-1-git-send-email-yuvalmin@broadcom.com>
From: Dmitry Kravkov <dmitry@broadcom.com>
bnx2x drivers configure coalescing incorrectly (e.g., as a result of a call
to 'ethtool -c'). Although this is almost invisible to the user (due to NAPI)
designated tests will show the configuration is incorrect.
Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: Ariel Elior <ariele@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
index d21742c..986edbf 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
@@ -1621,7 +1621,7 @@ struct bnx2x {
u16 rx_ticks_int;
u16 rx_ticks;
/* Maximal coalescing timeout in us */
-#define BNX2X_MAX_COALESCE_TOUT (0xf0*12)
+#define BNX2X_MAX_COALESCE_TOUT (0xff*BNX2X_BTR)
u32 lin_cnt;
--
1.8.1.227.g44fe835
next prev parent reply other threads:[~2013-10-20 14:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-20 14:51 [PATCH net v2 0/9] bnx2x: Bug fixes patch series Yuval Mintz
2013-10-20 14:51 ` [PATCH net v2 1/9] bnx2x: Fix Maximum CoS estimation for VFs Yuval Mintz
2013-10-20 14:51 ` [PATCH net v2 2/9] bnx2x: Prevent an illegal pointer dereference during panic Yuval Mintz
2013-10-20 14:51 ` [PATCH net v2 3/9] bnx2x: Unlock VF-PF channel on MAC/VLAN config error Yuval Mintz
2013-10-20 14:51 ` Yuval Mintz [this message]
2013-10-20 14:51 ` [PATCH net v2 5/9] bnx2x: Fix config when SR-IOV and iSCSI are enabled Yuval Mintz
2013-10-20 14:51 ` [PATCH net v2 6/9] bnx2x: Prevent null pointer dereference on error flow Yuval Mintz
2013-10-20 14:51 ` [PATCH net v2 7/9] bnx2x: Lock DMAE when used by statistic flow Yuval Mintz
2013-10-20 14:51 ` [PATCH net v2 8/9] bnx2x: Don't pretend during register dump Yuval Mintz
2013-10-20 14:51 ` [PATCH net v2 9/9] bnx2x: Set NETIF_F_HIGHDMA unconditionally Yuval Mintz
2013-10-21 22:32 ` [PATCH net v2 0/9] bnx2x: Bug fixes patch series David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382280694-8428-5-git-send-email-yuvalmin@broadcom.com \
--to=yuvalmin@broadcom.com \
--cc=ariele@broadcom.com \
--cc=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).