From: Joe Perches <joe@perches.com>
To: Tino Reichardt <milky-kernel@mcmilk.de>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCHSET net-next v3 00/07] Support for byte queue limits on various drivers
Date: Sun, 20 Oct 2013 12:38:04 -0700 [thread overview]
Message-ID: <1382297884.2041.48.camel@joe-AO722> (raw)
In-Reply-To: <1382296991-20289-1-git-send-email-milky-kernel@mcmilk.de>
On Sun, 2013-10-20 at 21:23 +0200, Tino Reichardt wrote:
> Hello again,
Hi again Tino.
> "if (likely(bql_disable == false))" was replaced by
> "if (unlikely(bql_disable))" ...
Sorry for suggesting this, but it's not an
equivalent transform unless the then & else
paths are also inverted.
Here there are no else branches.
Doesn't this need to be?
from:
if (likely(bql_disable == false))
to:
if (likely(!bql_disable))
next prev parent reply other threads:[~2013-10-20 19:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-20 19:23 [PATCHSET net-next v3 00/07] Support for byte queue limits on various drivers Tino Reichardt
2013-10-20 19:23 ` [PATCH net-next v3 01/07] 8139too: Support for byte queue limits Tino Reichardt
2013-10-20 19:23 ` [PATCH net-next v3 02/07] r8169: " Tino Reichardt
2013-10-21 9:55 ` Ben Hutchings
2013-10-21 13:38 ` Sergei Shtylyov
2013-10-20 19:23 ` [PATCH net-next v3 03/07] tulip: " Tino Reichardt
2013-10-21 3:00 ` Grant Grundler
2013-10-20 19:23 ` [PATCH net-next v3 04/07] via-rhine: " Tino Reichardt
2013-10-20 19:23 ` [PATCH net-next v3 05/07] via-velocity: " Tino Reichardt
2013-10-20 19:23 ` [PATCH net-next v3 06/07] 3c59x: " Tino Reichardt
2013-10-20 19:23 ` [PATCH net-next v3 07/07] natsemi: " Tino Reichardt
2013-10-20 19:38 ` Joe Perches [this message]
2013-10-20 20:19 ` [PATCHSET net-next v3 00/07] Support for byte queue limits on various drivers Tino Reichardt
2013-10-20 21:13 ` Andi Kleen
2013-10-21 9:53 ` Ben Hutchings
2013-10-20 22:07 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382297884.2041.48.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=milky-kernel@mcmilk.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox