public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Tom D'Alba <tomster595@gmail.com>
To: netdev@vger.kernel.org
Cc: Tom D'Alba <dalbat@rpi.edu>
Subject: [PATCH net-next] jazzsonic: printk() style fixes
Date: Thu, 24 Oct 2013 21:39:40 +0000	[thread overview]
Message-ID: <1382650780-24114-1-git-send-email-tomster595@gmail.com> (raw)

From: Tom D'Alba <dalbat@rpi.edu>

Fixed printk() format by adding correct KERN_ statuses.

Reviewed-by: Nicholas Guthrie <nickg4317@gmail.com>
Reviewed-by: Sarah Williams <swilliams704@gmail.com>
Reviewed-by: Jason Lee <calccrypto@gmail.com>
Signed-off-by: Tom D'Alba <dalbat@rpi.edu>
---
 drivers/net/ethernet/natsemi/jazzsonic.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/natsemi/jazzsonic.c b/drivers/net/ethernet/natsemi/jazzsonic.c
index 79257f7..3a04d32 100644
--- a/drivers/net/ethernet/natsemi/jazzsonic.c
+++ b/drivers/net/ethernet/natsemi/jazzsonic.c
@@ -135,7 +135,7 @@ static int sonic_probe1(struct net_device *dev)
 	 */
 	silicon_revision = SONIC_READ(SONIC_SR);
 	if (sonic_debug > 1)
-		printk("SONIC Silicon Revision = 0x%04x\n",silicon_revision);
+	  printk(KERN_INFO "SONIC Silicon Revision = 0x%04x\n",silicon_revision);
 
 	i = 0;
 	while (known_revisions[i] != 0xffff &&
@@ -143,13 +143,13 @@ static int sonic_probe1(struct net_device *dev)
 		i++;
 
 	if (known_revisions[i] == 0xffff) {
-		printk("SONIC ethernet controller not found (0x%4x)\n",
+		printk(KERN_ERR "SONIC ethernet controller not found (0x%4x)\n",
 		       silicon_revision);
 		goto out;
 	}
 
 	if (sonic_debug  &&  version_printed++ == 0)
-		printk(version);
+	      printk(KERN_INFO version);
 
 	printk(KERN_INFO "%s: Sonic ethernet found at 0x%08lx, ",
 	       dev_name(lp->device), dev->base_addr);
-- 
1.8.1.2

             reply	other threads:[~2013-10-24 21:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-24 21:39 Tom D'Alba [this message]
2013-10-24 21:50 ` [PATCH net-next] jazzsonic: printk() style fixes Sergei Shtylyov
2013-10-24 21:54 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382650780-24114-1-git-send-email-tomster595@gmail.com \
    --to=tomster595@gmail.com \
    --cc=dalbat@rpi.edu \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox