From: "Luke C. Jones" <luke.christopher.jones@gmail.com>
To: netdev@vger.kernel.org
Cc: "Luke C. Jones" <jonesl4@rpi.edu>
Subject: [PATCH net-next] ns83820: printk() cleanup
Date: Thu, 24 Oct 2013 21:45:06 +0000 [thread overview]
Message-ID: <1382651106-24550-1-git-send-email-Luke.Christopher.Jones@gmail.com> (raw)
From: "Luke C. Jones" <jonesl4@rpi.edu>
In an effort to bring all printk calls up to style standards,
added log levels to printk calls.
Reviewed-by: Mike Mathis <mathim2@rpi.edu>
Reviewed-by: Jonathan Beekman <beekmj@rpi.edu>
Signed-off-by: Luke C. Jones <jonesl4@rpi.edu>
---
drivers/net/ethernet/natsemi/ns83820.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c
index d3b4700..d7f849d 100644
--- a/drivers/net/ethernet/natsemi/ns83820.c
+++ b/drivers/net/ethernet/natsemi/ns83820.c
@@ -1580,7 +1580,7 @@ static void ns83820_tx_timeout(struct net_device *ndev)
{
u32 isr;
isr = readl(dev->base + ISR);
- printk("irq: %08x imr: %08x\n", isr, dev->IMR_cache);
+ printk(KERN_DEBUG "irq: %08x imr: %08x\n", isr, dev->IMR_cache);
ns83820_do_isr(ndev, isr);
}
#endif
@@ -1603,7 +1603,7 @@ static void ns83820_tx_watch(unsigned long data)
struct ns83820 *dev = PRIV(ndev);
#if defined(DEBUG)
- printk("ns83820_tx_watch: %u %u %d\n",
+ printk(KERN_DEBUG "ns83820_tx_watch: %u %u %d\n",
dev->tx_done_idx, dev->tx_free_idx, atomic_read(&dev->nr_tx_skbs)
);
#endif
@@ -2026,7 +2026,7 @@ static int ns83820_init_one(struct pci_dev *pci_dev,
goto out_free_irq;
}
- printk("%s: ns83820.c: 0x22c: %08x, subsystem: %04x:%04x\n",
+ printk(KERN_INFO "%s: ns83820.c: 0x22c: %08x, subsystem: %04x:%04x\n",
ndev->name, le32_to_cpu(readl(dev->base + 0x22c)),
pci_dev->subsystem_vendor, pci_dev->subsystem_device);
--
1.8.1.2
next reply other threads:[~2013-10-24 21:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 21:45 Luke C. Jones [this message]
2013-10-24 22:38 ` [PATCH net-next] ns83820: printk() cleanup Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382651106-24550-1-git-send-email-Luke.Christopher.Jones@gmail.com \
--to=luke.christopher.jones@gmail.com \
--cc=jonesl4@rpi.edu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox