[PATCH net-next] ns83820: printk() cleanup

[PATCH net-next] ns83820: printk() cleanup

[Luke C. Jones]

From: "Luke C. Jones" <jonesl4@rpi.edu>

In an effort to bring all printk calls up to style standards,
added log levels to printk calls.

Reviewed-by: Mike Mathis <mathim2@rpi.edu>
Reviewed-by: Jonathan Beekman <beekmj@rpi.edu>
Signed-off-by: Luke C. Jones <jonesl4@rpi.edu>
---
 drivers/net/ethernet/natsemi/ns83820.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c
index d3b4700..d7f849d 100644
--- a/drivers/net/ethernet/natsemi/ns83820.c
+++ b/drivers/net/ethernet/natsemi/ns83820.c
@@ -1580,7 +1580,7 @@ static void ns83820_tx_timeout(struct net_device *ndev)
 	{
 		u32 isr;
 		isr = readl(dev->base + ISR);
-		printk("irq: %08x imr: %08x\n", isr, dev->IMR_cache);
+		printk(KERN_DEBUG "irq: %08x imr: %08x\n", isr, dev->IMR_cache);
 		ns83820_do_isr(ndev, isr);
 	}
 #endif
@@ -1603,7 +1603,7 @@ static void ns83820_tx_watch(unsigned long data)
 	struct ns83820 *dev = PRIV(ndev);
 
 #if defined(DEBUG)
-	printk("ns83820_tx_watch: %u %u %d\n",
+	printk(KERN_DEBUG "ns83820_tx_watch: %u %u %d\n",
 		dev->tx_done_idx, dev->tx_free_idx, atomic_read(&dev->nr_tx_skbs)
 		);
 #endif
@@ -2026,7 +2026,7 @@ static int ns83820_init_one(struct pci_dev *pci_dev,
 		goto out_free_irq;
 	}
 
-	printk("%s: ns83820.c: 0x22c: %08x, subsystem: %04x:%04x\n",
+	printk(KERN_INFO "%s: ns83820.c: 0x22c: %08x, subsystem: %04x:%04x\n",
 		ndev->name, le32_to_cpu(readl(dev->base + 0x22c)),
 		pci_dev->subsystem_vendor, pci_dev->subsystem_device);
 
-- 
1.8.1.2

Re: [PATCH net-next] ns83820: printk() cleanup

[Joe Perches]

On Thu, 2013-10-24 at 21:45 +0000, Luke C. Jones wrote:
> In an effort to bring all printk calls up to style standards,
> added log levels to printk calls.
[]
> diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c
[]
> @@ -1580,7 +1580,7 @@ static void ns83820_tx_timeout(struct net_device *ndev)
>  	{
>  		u32 isr;
>  		isr = readl(dev->base + ISR);
> -		printk("irq: %08x imr: %08x\n", isr, dev->IMR_cache);
> +		printk(KERN_DEBUG "irq: %08x imr: %08x\n", isr, dev->IMR_cache);

netdev_dbg(ndev, etc...)

> @@ -1603,7 +1603,7 @@ static void ns83820_tx_watch(unsigned long data)
>  	struct ns83820 *dev = PRIV(ndev);
>  
>  #if defined(DEBUG)
> -	printk("ns83820_tx_watch: %u %u %d\n",
> +	printk(KERN_DEBUG "ns83820_tx_watch: %u %u %d\n",
>  		dev->tx_done_idx, dev->tx_free_idx, atomic_read(&dev->nr_tx_skbs)
>  		);

netdev_dbg()

>  #endif
> @@ -2026,7 +2026,7 @@ static int ns83820_init_one(struct pci_dev *pci_dev,
>  		goto out_free_irq;
>  	}
>  
> -	printk("%s: ns83820.c: 0x22c: %08x, subsystem: %04x:%04x\n",
> +	printk(KERN_INFO "%s: ns83820.c: 0x22c: %08x, subsystem: %04x:%04x\n",
>  		ndev->name, le32_to_cpu(readl(dev->base + 0x22c)),
>  		pci_dev->subsystem_vendor, pci_dev->subsystem_device);
>  

netdev_info()