From: Joe Perches <joe@perches.com>
To: Drew McGowen <quantumdude836@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] natsemi: fix legacy printk() style
Date: Thu, 24 Oct 2013 15:33:16 -0700 [thread overview]
Message-ID: <1382653996.22433.84.camel@joe-AO722> (raw)
In-Reply-To: <1382650646-24009-1-git-send-email-quantumdude836@gmail.com>
On Thu, 2013-10-24 at 21:37 +0000, Drew McGowen wrote:
> Fixed printk() calls to use KERN_* prefix (some were not changed because they
> are continuations of a previous line).
[]
> diff --git a/drivers/net/ethernet/natsemi/natsemi.c b/drivers/net/ethernet/natsemi/natsemi.c
[]
> @@ -814,7 +814,7 @@ static int natsemi_probe1(struct pci_dev *pdev, const struct pci_device_id *ent)
> #ifndef MODULE
> static int printed_version;
> if (!printed_version++)
> - printk(version);
> + printk(KERN_INFO version);
pr_info_once("%s\n", version);
And remove the trailing newline from version
> @@ -3360,7 +3360,7 @@ static int __init natsemi_init_mod (void)
> {
> /* when a module, this is printed whether or not devices are found in probe */
> #ifdef MODULE
> - printk(version);
> + printk(KERN_INFO version);
pr_info("%s\n", version);
Nicer to use netdev_<level> too.
prev parent reply other threads:[~2013-10-24 22:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 21:37 [PATCH net-next] natsemi: fix legacy printk() style Drew McGowen
2013-10-24 22:33 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382653996.22433.84.camel@joe-AO722 \
--to=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=quantumdude836@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox