From: Joe Perches <joe@perches.com>
To: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
Cc: Alexander Aring <alex.aring@gmail.com>,
"linux-zigbee-devel@lists.sourceforge.net"
<linux-zigbee-devel@lists.sourceforge.net>,
"werner@almesberger.net" <werner@almesberger.net>,
"dbaryshkov@gmail.com" <dbaryshkov@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 5/5] 6lowpan: remove unecessary break
Date: Thu, 24 Oct 2013 20:40:51 -0700 [thread overview]
Message-ID: <1382672451.2068.1.camel@joe-AO722> (raw)
In-Reply-To: <EFDF4460-F8D0-4721-82F1-ABC3D5F75FDA@gmail.com>
On Fri, 2013-10-25 at 07:28 +0400, Alexander Smirnov wrote:
> > 25 окт. 2013 г., в 0:51, Alexander Aring <alex.aring@gmail.com> написал(а):
[]
> > diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
[]
> > @@ -440,7 +440,6 @@ lowpan_uncompress_udp_header(struct sk_buff *skb, struct udphdr *uh)
> > default:
> > pr_debug("ERROR: unknown UDP format\n");
> > goto err;
> > - break;
> > }
> >
>
> It's not an unnecessary, it's let say a "good coding practice" to have a break for every case including default.
Hello Alexanders:
Some would otherwise say it's a poor practice.
next prev parent reply other threads:[~2013-10-25 3:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 20:51 [PATCH net-next 0/5] trivial changes Alexander Aring
[not found] ` <1382647904-11311-1-git-send-email-alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-10-24 20:51 ` [PATCH net-next 1/5] 6lowpan: remove unnecessary ret variable Alexander Aring
2013-10-24 20:51 ` [PATCH net-next 3/5] 6lowpan: use netdev_alloc_skb instead dev_alloc_skb Alexander Aring
2013-10-26 5:42 ` David Miller
[not found] ` <20131026.014214.1636999222808937267.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2013-10-26 6:01 ` Joe Perches
2013-10-26 21:32 ` David Miller
2013-10-24 20:51 ` [PATCH net-next 4/5] 6lowpan: remove skb->dev assignment Alexander Aring
2013-10-24 20:51 ` [PATCH net-next 5/5] 6lowpan: remove unecessary break Alexander Aring
2013-10-25 3:28 ` Alexander Smirnov
2013-10-25 3:40 ` Joe Perches [this message]
2013-10-25 3:42 ` David Miller
2013-10-25 13:05 ` Sergei Shtylyov
[not found] ` <526A6CB2.1040007-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2013-10-25 13:11 ` Alexander Smirnov
2013-10-24 20:51 ` [PATCH net-next 2/5] 6lowpan: remove unnecessary check on err >= 0 Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382672451.2068.1.camel@joe-AO722 \
--to=joe@perches.com \
--cc=alex.aring@gmail.com \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=werner@almesberger.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).