From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wang Weidong Subject: [PATCH net-next 1/4] sctp: merge two if statements to one Date: Fri, 25 Oct 2013 11:45:45 +0800 Message-ID: <1382672748-10156-2-git-send-email-wangweidong1@huawei.com> References: <1382672748-10156-1-git-send-email-wangweidong1@huawei.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , , , To: , Return-path: Received: from szxga01-in.huawei.com ([119.145.14.64]:10027 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755334Ab3JYDsQ (ORCPT ); Thu, 24 Oct 2013 23:48:16 -0400 In-Reply-To: <1382672748-10156-1-git-send-email-wangweidong1@huawei.com> Sender: netdev-owner@vger.kernel.org List-ID: Two if statements do the same work, maybe we can merge them to one. There is just code simplification, no functional changes. Signed-off-by: Wang Weidong --- net/sctp/auth.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/net/sctp/auth.c b/net/sctp/auth.c index 8c4fa5d..19fb0ae 100644 --- a/net/sctp/auth.c +++ b/net/sctp/auth.c @@ -539,18 +539,14 @@ struct sctp_hmac *sctp_auth_asoc_get_hmac(const struct sctp_association *asoc) for (i = 0; i < n_elt; i++) { id = ntohs(hmacs->hmac_ids[i]); - /* Check the id is in the supported range */ - if (id > SCTP_AUTH_HMAC_ID_MAX) { - id = 0; - continue; - } - - /* See is we support the id. Supported IDs have name and + /* Check the id is in the supported range. And + * see is we support the id. Supported IDs have name and * length fields set, so that we can allocated and use * them. We can safely just check for name, for without the * name, we can't allocate the TFM. */ - if (!sctp_hmac_list[id].hmac_name) { + if (id > SCTP_AUTH_HMAC_ID_MAX || + !sctp_hmac_list[id].hmac_name) { id = 0; continue; } -- 1.7.12