netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Boeckel <mathstuf@gmail.com>
To: netdev@vger.kernel.org
Cc: Ben Boeckel <mathstuf@gmail.com>
Subject: [PATCH net-next 4/6] smc9194: replace printk with netdev_ calls
Date: Fri, 25 Oct 2013 02:27:00 -0400	[thread overview]
Message-ID: <1382682422-22677-5-git-send-email-mathstuf@gmail.com> (raw)
In-Reply-To: <1382682422-22677-1-git-send-email-mathstuf@gmail.com>

Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
---
 drivers/net/ethernet/smsc/smc9194.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/net/ethernet/smsc/smc9194.c b/drivers/net/ethernet/smsc/smc9194.c
index e85c2e7..c0a45a9 100644
--- a/drivers/net/ethernet/smsc/smc9194.c
+++ b/drivers/net/ethernet/smsc/smc9194.c
@@ -55,7 +55,7 @@
  ----------------------------------------------------------------------------*/
 
 static const char version[] =
-	"smc9194.c:v0.14 12/15/00 by Erik Stahlman (erik@vt.edu)\n";
+	"smc9194.c:v0.14 12/15/00 by Erik Stahlman (erik@vt.edu)";
 
 #include <linux/module.h>
 #include <linux/kernel.h>
@@ -612,7 +612,7 @@ static void smc_hardware_send_packet( struct net_device * dev )
 	packet_no = inb( ioaddr + PNR_ARR + 1 );
 	if ( packet_no & 0x80 ) {
 		/* or isn't there?  BAD CHIP! */
-		printk(KERN_DEBUG CARDNAME": Memory allocation failed.\n");
+		netdev_dbg(dev, CARDNAME": Memory allocation failed.\n");
 		dev_kfree_skb_any(skb);
 		lp->saved_skb = NULL;
 		netif_wake_queue(dev);
@@ -865,7 +865,6 @@ static const struct net_device_ops smc_netdev_ops = {
 static int __init smc_probe(struct net_device *dev, int ioaddr)
 {
 	int i, memory, retval;
-	static unsigned version_printed;
 	unsigned int bank;
 
 	const char *version_string;
@@ -937,8 +936,7 @@ static int __init smc_probe(struct net_device *dev, int ioaddr)
 	   It might be prudent to check a listing of MAC addresses
 	   against the hardware address, or do some other tests. */
 
-	if (version_printed++ == 0)
-		printk("%s", version);
+	pr_info_once("%s\n", version);
 
 	/* fill in some of the fields */
 	dev->base_addr = ioaddr;
@@ -1027,18 +1025,18 @@ static int __init smc_probe(struct net_device *dev, int ioaddr)
 
 	/* now, print out the card info, in a short format.. */
 
-	printk("%s: %s(r:%d) at %#3x IRQ:%d INTF:%s MEM:%db ", dev->name,
+	netdev_info(dev, "%s: %s(r:%d) at %#3x IRQ:%d INTF:%s MEM:%db ", dev->name,
 		version_string, revision_register & 0xF, ioaddr, dev->irq,
 		if_string, memory );
 	/*
 	 . Print the Ethernet address
 	*/
-	printk("ADDR: %pM\n", dev->dev_addr);
+	netdev_info(dev, "ADDR: %pM\n", dev->dev_addr);
 
 	/* Grab the IRQ */
       	retval = request_irq(dev->irq, smc_interrupt, 0, DRV_NAME, dev);
       	if (retval) {
-		printk("%s: unable to get IRQ %d (irqval=%d).\n", DRV_NAME,
+		netdev_warn(dev, "%s: unable to get IRQ %d (irqval=%d).\n", DRV_NAME,
 			dev->irq, retval);
   	  	goto err_out;
       	}
@@ -1061,13 +1059,14 @@ static void print_packet( byte * buf, int length )
 	int remainder;
 	int lines;
 
-	printk("Packet of length %d\n", length);
+	printk(KERN_DEBUG "Packet of length %d\n", length);
 	lines = length / 16;
 	remainder = length % 16;
 
 	for ( i = 0; i < lines ; i ++ ) {
 		int cur;
 
+		printk(KERN_DEBUG);
 		for ( cur = 0; cur < 8; cur ++ ) {
 			byte a, b;
 
@@ -1077,6 +1076,7 @@ static void print_packet( byte * buf, int length )
 		}
 		printk("\n");
 	}
+	printk(KERN_DEBUG);
 	for ( i = 0; i < remainder/2 ; i++ ) {
 		byte a, b;
 
@@ -1151,7 +1151,7 @@ static void smc_timeout(struct net_device *dev)
 {
 	/* If we get here, some higher level has decided we are broken.
 	   There should really be a "kick me" function call instead. */
-	printk(KERN_WARNING CARDNAME": transmit timed out, %s?\n",
+	netdev_warn(dev, CARDNAME": transmit timed out, %s?\n",
 		tx_done(dev) ? "IRQ conflict" :
 		"network cable problem");
 	/* "kick" the adaptor */
@@ -1323,7 +1323,7 @@ static void smc_tx( struct net_device * dev )
 	dev->stats.tx_errors++;
 	if ( tx_status & TS_LOSTCAR ) dev->stats.tx_carrier_errors++;
 	if ( tx_status & TS_LATCOL  ) {
-		printk(KERN_DEBUG CARDNAME
+		netdev_dbg(dev, CARDNAME
 			": Late collision occurred on last xmit.\n");
 		dev->stats.tx_window_errors++;
 	}
@@ -1332,7 +1332,7 @@ static void smc_tx( struct net_device * dev )
 #endif
 
 	if ( tx_status & TS_SUCCESS ) {
-		printk(CARDNAME": Successful packet caused interrupt\n");
+		netdev_info(dev, CARDNAME": Successful packet caused interrupt\n");
 	}
 	/* re-enable transmit */
 	SMC_SELECT_BANK( 0 );
-- 
1.8.3.1

  parent reply	other threads:[~2013-10-25  6:27 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-25  6:26 [PATCH net-next 0/6] smsc: replace printk with netdev_ calls Ben Boeckel
2013-10-25  6:26 ` [PATCH net-next 1/6] epic100: " Ben Boeckel
2013-10-25  6:41   ` Joe Perches
2013-11-01  4:31     ` Ben Boeckel
2013-10-25  6:26 ` [PATCH net-next 2/6] smc91x: " Ben Boeckel
2013-10-25  6:26 ` [PATCH net-next 3/6] smc911x: " Ben Boeckel
2013-10-25  6:27 ` Ben Boeckel [this message]
2013-10-25  6:27 ` [PATCH net-next 5/6] smc91c92_cs: " Ben Boeckel
2013-10-25  6:27 ` [PATCH net-next 6/6] smsc9420: " Ben Boeckel
2013-11-01  4:27 ` [PATCHv2 net-next 0/7] smsc: " Ben Boeckel
2013-11-01  4:27   ` [PATCHv2 net-next 1/7] epic100: " Ben Boeckel
2013-11-01  4:36     ` Joe Perches
2013-11-01  4:27   ` [PATCHv2 net-next 2/7] smc91x: " Ben Boeckel
2013-11-01  4:27   ` [PATCHv2 net-next 3/7] smc911x: " Ben Boeckel
2013-11-01  4:27   ` [PATCHv2 net-next 4/7] smsc911x: " Ben Boeckel
2013-11-01  4:27   ` [PATCHv2 net-next 5/7] smc9194: " Ben Boeckel
2013-11-01  4:27   ` [PATCHv2 net-next 6/7] smc91c92_cs: " Ben Boeckel
2013-11-01  4:27   ` [PATCHv2 net-next 7/7] smsc9420: " Ben Boeckel
2013-11-01 12:53 ` [PATCHv2 net-next 0/7] smsc: " Ben Boeckel
2013-11-01 12:53   ` [PATCHv3 net-next 1/7] epic100: " Ben Boeckel
2013-11-01 12:53   ` [PATCHv3 net-next 2/7] smc91x: " Ben Boeckel
2013-11-01 12:53   ` [PATCHv3 net-next 3/7] smc911x: " Ben Boeckel
2013-11-01 12:53   ` [PATCHv3 net-next 4/7] smsc911x: " Ben Boeckel
2013-11-01 12:53   ` [PATCHv3 net-next 5/7] smc9194: " Ben Boeckel
2013-11-01 12:53   ` [PATCHv3 net-next 6/7] smc91c92_cs: " Ben Boeckel
2013-11-01 12:53   ` [PATCHv3 net-next 7/7] smsc9420: " Ben Boeckel
2013-11-02  5:21   ` [PATCHv2 net-next 0/7] smsc: " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382682422-22677-5-git-send-email-mathstuf@gmail.com \
    --to=mathstuf@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).