* [PATCH v2] octeon_mgmt: drop redundant mac address check
@ 2013-10-29 23:09 Luka Perkov
2013-10-30 2:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Luka Perkov @ 2013-10-29 23:09 UTC (permalink / raw)
To: netdev; +Cc: Luka Perkov, David Miller
Checking if MAC address is valid using is_valid_ether_addr() is already done in
of_get_mac_address().
Signed-off-by: Luka Perkov <luka@openwrt.org>
Acked-by: David Daney <david.daney@cavium.com>
CC: David Miller <davem@davemloft.net>
---
v1->v2:
* cosmetic commit message fix based on comment from David Miller
---
drivers/net/ethernet/octeon/octeon_mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/octeon/octeon_mgmt.c b/drivers/net/ethernet/octeon/octeon_mgmt.c
index 622aa75..1b326cbc 100644
--- a/drivers/net/ethernet/octeon/octeon_mgmt.c
+++ b/drivers/net/ethernet/octeon/octeon_mgmt.c
@@ -1545,7 +1545,7 @@ static int octeon_mgmt_probe(struct platform_device *pdev)
mac = of_get_mac_address(pdev->dev.of_node);
- if (mac && is_valid_ether_addr(mac))
+ if (mac)
memcpy(netdev->dev_addr, mac, ETH_ALEN);
else
eth_hw_addr_random(netdev);
--
1.8.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] octeon_mgmt: drop redundant mac address check
2013-10-29 23:09 [PATCH v2] octeon_mgmt: drop redundant mac address check Luka Perkov
@ 2013-10-30 2:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-10-30 2:53 UTC (permalink / raw)
To: luka; +Cc: netdev
From: Luka Perkov <luka@openwrt.org>
Date: Wed, 30 Oct 2013 00:09:12 +0100
> Checking if MAC address is valid using is_valid_ether_addr() is already done in
> of_get_mac_address().
>
> Signed-off-by: Luka Perkov <luka@openwrt.org>
> Acked-by: David Daney <david.daney@cavium.com>
> CC: David Miller <davem@davemloft.net>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-30 2:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-29 23:09 [PATCH v2] octeon_mgmt: drop redundant mac address check Luka Perkov
2013-10-30 2:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).