From: Joe Perches <joe@perches.com>
To: Ben Boeckel <mathstuf@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCHv2 net-next 1/7] epic100: replace printk with netdev_ calls
Date: Thu, 31 Oct 2013 21:36:12 -0700 [thread overview]
Message-ID: <1383280572.13084.2.camel@joe-AO722> (raw)
In-Reply-To: <1383280043-13552-2-git-send-email-mathstuf@gmail.com>
On Fri, 2013-11-01 at 00:27 -0400, Ben Boeckel wrote:
> Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
Nice (really, nicely done!) but:
> diff --git a/drivers/net/ethernet/smsc/epic100.c b/drivers/net/ethernet/smsc/epic100.c
[]
> @@ -1324,7 +1316,7 @@ static int epic_close(struct net_device *dev)
> ep->rx_ring[i].buflength = 0;
> if (skb) {
> pci_unmap_single(pdev, ep->rx_ring[i].bufaddr,
> - ep->rx_buf_sz, PCI_DMA_FROMDEVICE);
> + ep->rx_buf_sz, PCI_DMA_FROMDEVICE);
Please either mention the whitespace changes in the
changelog or don't do them in the same patch.
next prev parent reply other threads:[~2013-11-01 4:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 6:26 [PATCH net-next 0/6] smsc: replace printk with netdev_ calls Ben Boeckel
2013-10-25 6:26 ` [PATCH net-next 1/6] epic100: " Ben Boeckel
2013-10-25 6:41 ` Joe Perches
2013-11-01 4:31 ` Ben Boeckel
2013-10-25 6:26 ` [PATCH net-next 2/6] smc91x: " Ben Boeckel
2013-10-25 6:26 ` [PATCH net-next 3/6] smc911x: " Ben Boeckel
2013-10-25 6:27 ` [PATCH net-next 4/6] smc9194: " Ben Boeckel
2013-10-25 6:27 ` [PATCH net-next 5/6] smc91c92_cs: " Ben Boeckel
2013-10-25 6:27 ` [PATCH net-next 6/6] smsc9420: " Ben Boeckel
2013-11-01 4:27 ` [PATCHv2 net-next 0/7] smsc: " Ben Boeckel
2013-11-01 4:27 ` [PATCHv2 net-next 1/7] epic100: " Ben Boeckel
2013-11-01 4:36 ` Joe Perches [this message]
2013-11-01 4:27 ` [PATCHv2 net-next 2/7] smc91x: " Ben Boeckel
2013-11-01 4:27 ` [PATCHv2 net-next 3/7] smc911x: " Ben Boeckel
2013-11-01 4:27 ` [PATCHv2 net-next 4/7] smsc911x: " Ben Boeckel
2013-11-01 4:27 ` [PATCHv2 net-next 5/7] smc9194: " Ben Boeckel
2013-11-01 4:27 ` [PATCHv2 net-next 6/7] smc91c92_cs: " Ben Boeckel
2013-11-01 4:27 ` [PATCHv2 net-next 7/7] smsc9420: " Ben Boeckel
2013-11-01 12:53 ` [PATCHv2 net-next 0/7] smsc: " Ben Boeckel
2013-11-01 12:53 ` [PATCHv3 net-next 1/7] epic100: " Ben Boeckel
2013-11-01 12:53 ` [PATCHv3 net-next 2/7] smc91x: " Ben Boeckel
2013-11-01 12:53 ` [PATCHv3 net-next 3/7] smc911x: " Ben Boeckel
2013-11-01 12:53 ` [PATCHv3 net-next 4/7] smsc911x: " Ben Boeckel
2013-11-01 12:53 ` [PATCHv3 net-next 5/7] smc9194: " Ben Boeckel
2013-11-01 12:53 ` [PATCHv3 net-next 6/7] smc91c92_cs: " Ben Boeckel
2013-11-01 12:53 ` [PATCHv3 net-next 7/7] smsc9420: " Ben Boeckel
2013-11-02 5:21 ` [PATCHv2 net-next 0/7] smsc: " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383280572.13084.2.camel@joe-AO722 \
--to=joe@perches.com \
--cc=mathstuf@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).