From: Joe Perches <joe@perches.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
Alexey Orishko <alexey.orishko@gmail.com>
Subject: Re: [PATCH net-next 17/24] net: cdc_ncm: use netif_* and dev_* instead of pr_*
Date: Fri, 01 Nov 2013 03:36:54 -0700 [thread overview]
Message-ID: <1383302214.13084.6.camel@joe-AO722> (raw)
In-Reply-To: <1383301021-16613-18-git-send-email-bjorn@mork.no>
On Fri, 2013-11-01 at 11:16 +0100, Bjørn Mork wrote:
> Take advantage of standard device name prefixing and
> netdevice msglvl control where possible.
Nice, thanks.
You did most all the multi-line statement
alignment perfectly but missed a couple.
Maybe in a follow-on patch.
> diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
[]
> @@ -1031,17 +1035,13 @@ cdc_ncm_speed_change(struct usbnet *dev,
> * device speed. Do print it instead.
> */
> if ((tx_speed > 1000000) && (rx_speed > 1000000)) {
> - printk(KERN_INFO KBUILD_MODNAME
> - ": %s: %u mbit/s downlink "
> - "%u mbit/s uplink\n",
> - dev->net->name,
> + netif_info(dev, link, dev->net,
> + "%u mbit/s downlink %u mbit/s uplink\n",
> (unsigned int)(rx_speed / 1000000U),
> (unsigned int)(tx_speed / 1000000U));
> } else {
> - printk(KERN_INFO KBUILD_MODNAME
> - ": %s: %u kbit/s downlink "
> - "%u kbit/s uplink\n",
> - dev->net->name,
> + netif_info(dev, link, dev->net,
> + "%u kbit/s downlink %u kbit/s uplink\n",
> (unsigned int)(rx_speed / 1000U),
> (unsigned int)(tx_speed / 1000U));
> }
next prev parent reply other threads:[~2013-11-01 10:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 10:16 [PATCH net-next 00/24] cdc_ncm: many small and mostly trivial fixes Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 01/24] net: cdc_ncm: simplify and optimize frame padding Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 02/24] net: cdc_ncm: add include protection to cdc_ncm.h Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 03/24] net: cdc_ncm: remove redundant "intf" field Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 04/24] net: cdc_ncm: remove redundant endpoint pointers Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 07/24] net: cdc_ncm: remove tx_speed and rx_speed fields Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 08/24] net: cdc_ncm: remove ncm_parm field Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 09/24] net: cdc_ncm: fix SET_MAX_DATAGRAM_SIZE Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 10/24] net: cdc_ncm: remove descriptor pointers Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 11/24] net: cdc_ncm: only the control intf can be probed Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 12/24] net: cdc_ncm: no point in filling up the NTBs if we send ZLPs Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 13/24] net: cdc_ncm: remove probe and disconnect wrappers Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 15/24] net: cdc_ncm: set correct dev->hard_mtu Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 17/24] net: cdc_ncm: use netif_* and dev_* instead of pr_* Bjørn Mork
2013-11-01 10:36 ` Joe Perches [this message]
2013-11-04 8:59 ` Bjørn Mork
[not found] ` <1383301021-16613-1-git-send-email-bjorn-yOkvZcmFvRU@public.gmane.org>
2013-11-01 10:16 ` [PATCH net-next 05/24] net: cdc_ncm: remove redundant netdev field Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 06/24] net: cdc_ncm: remove unused udev field Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 14/24] net: cdc_ncm: remove ethtool ops Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 16/24] net: cdc_ncm: log the length we warn about Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 18/24] net: cdc_ncm: log signatures in hex Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 19/24] net: cdc_ncm: endian convert constants instead of variables Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 20/24] net: cdc_ncm: drop "extern" from header declarations Bjørn Mork
2013-11-01 10:17 ` [PATCH net-next 23/24] net: cdc_ncm: improve bind error debug messages Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 21/24] net: cdc_ncm: refactoring cdc_ncm_setup Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 22/24] net: cdc_ncm: return proper error if setup fails Bjørn Mork
2013-11-01 10:17 ` [PATCH net-next 24/24] net: cdc_ncm: no not set tx_max higher than the device supports Bjørn Mork
2013-11-02 6:02 ` [PATCH net-next 00/24] cdc_ncm: many small and mostly trivial fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383302214.13084.6.camel@joe-AO722 \
--to=joe@perches.com \
--cc=alexey.orishko@gmail.com \
--cc=bjorn@mork.no \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).