From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH net-next 1/3] net: move pskb_put() to core code Date: Tue, 5 Nov 2013 18:33:44 +0000 Message-ID: <1383676424.2868.11.camel@bwh-desktop.uk.level5networks.com> References: <5044e9be63b6e0734670654e6249576e3be4279e.1381923854.git.mathias.krause@secunet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Steffen Klassert , Herbert Xu , Dmitry Tarnyagin , To: Mathias Krause Return-path: Received: from webmail.solarflare.com ([12.187.104.25]:35210 "EHLO webmail.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925Ab3KESdt (ORCPT ); Tue, 5 Nov 2013 13:33:49 -0500 In-Reply-To: <5044e9be63b6e0734670654e6249576e3be4279e.1381923854.git.mathias.krause@secunet.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2013-11-05 at 14:54 +0100, Mathias Krause wrote: > This function has usage beside IPsec so move it to the core skbuff code. > While doing so, give it some documentation and change its return type to > 'unsigned char *' to be in line with skb_put(). [...] > --- a/net/core/skbuff.c > +++ b/net/core/skbuff.c > @@ -1257,6 +1257,29 @@ free_skb: > EXPORT_SYMBOL(skb_pad); > > /** > + * pskb_put - add data to the tail of a potentially fragmented buffer > + * @skb: start of the buffer to use > + * @tail: tail fragment of the buffer to use > + * @len: amount of data to add > + * > + * This function extends the used data area of the potentially > + * fragmented buffer. &tail must be the last fragment of &skb -- or > + * &skb itself. If this would exceed the total buffer size the kernel Keep using @ to refer to the parameters in this description. Ben. > + * will panic. A pointer to the first byte of the extra data is > + * returned. > + */ [...] -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.