From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Alistair Popple <alistair@popple.id.au>,
netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 3/7] IBM Akebono: Add support for a new PHY to the IBM emac driver
Date: Wed, 06 Nov 2013 06:54:00 +1100 [thread overview]
Message-ID: <1383681240.4776.97.camel@pasglop> (raw)
In-Reply-To: <1383675404.2868.8.camel@bwh-desktop.uk.level5networks.com>
On Tue, 2013-11-05 at 18:16 +0000, Ben Hutchings wrote:
> On Tue, 2013-11-05 at 16:31 +1100, Alistair Popple wrote:
> [...]
> > --- a/drivers/net/ethernet/ibm/emac/Kconfig
> > +++ b/drivers/net/ethernet/ibm/emac/Kconfig
> > @@ -55,6 +55,10 @@ config IBM_EMAC_RGMII
> > bool
> > default n
> >
> > +config IBM_EMAC_RGMII_WOL
> > + bool
> > + default n
> > +
> [...]
>
> So no-one can even build-test this at present!
Patch 7/7 adds the select to the platform, isn't that sufficient ?
It's an SoC bit so there's little point making it generally
selectable by the user.
Alistair: The commit name should be different, it's not a PHY you are
adding, it's a PHY interface (the PHY itself is off chip).
Cheers,
Ben.
next prev parent reply other threads:[~2013-11-05 19:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1383629471-16979-1-git-send-email-alistair@popple.id.au>
2013-11-05 5:31 ` [PATCH 3/7] IBM Akebono: Add support for a new PHY to the IBM emac driver Alistair Popple
2013-11-05 18:16 ` Ben Hutchings
2013-11-05 19:54 ` Benjamin Herrenschmidt [this message]
2013-11-05 23:11 ` Ben Hutchings
2013-11-06 1:34 ` Alistair Popple
2013-11-06 16:40 ` Ben Hutchings
2013-11-07 2:39 ` Alistair Popple
2013-11-05 18:47 ` Florian Fainelli
2013-11-06 0:08 ` Alistair Popple
2013-11-06 0:16 ` Florian Fainelli
2013-11-06 1:38 ` Alistair Popple
2013-11-06 2:17 ` Benjamin Herrenschmidt
2013-11-06 2:23 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383681240.4776.97.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=alistair@popple.id.au \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).