From: Joe Perches <joe@perches.com>
To: Matthew Whitehead <tedheadster@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] 8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature
Date: Wed, 06 Nov 2013 15:49:13 -0800 [thread overview]
Message-ID: <1383781753.7940.38.camel@joe-AO722> (raw)
In-Reply-To: <1383771418-28616-1-git-send-email-tedheadster@gmail.com>
On Wed, 2013-11-06 at 15:56 -0500, Matthew Whitehead wrote:
> Removed the shared ei_debug variable. Replaced it by adding u32 msg_enable to
> the private struct ei_device. Now each 8390 ethernet instance has a per-device
> logging variable.
>
> Changed printk() calls to netdev_(dbg|info|warn|err) when possible.
Hello Matthew.
Ideally, some of these would use:
netif_<level>(struct ei_device *, type, struct net_device *, fmt, ...)
> @@ -352,10 +360,12 @@ static void
[]
> + if (ei_local->msg_enable & NETIF_MSG_HW)
> + netdev_dbg(dev, "resetting the 8390 t=%ld...\n", jiffies);
netif_dbg(ei_local, hw, dev, "resetting the 8390 t=%...\n", jiffies);
> +++ b/drivers/net/ethernet/8390/ax88796.c
> @@ -147,8 +149,8 @@ static void ax_reset_8390(struct net_device *dev)
> unsigned long reset_start_time = jiffies;
> void __iomem *addr = (void __iomem *)dev->base_addr;
>
> - if (ei_debug > 1)
> - netdev_dbg(dev, "resetting the 8390 t=%ld\n", jiffies);
> + if (ei_local->msg_enable & NETIF_MSG_HW)
> + netdev_dbg(dev, "resetting the 8390 t=%ld...\n", jiffies);
netif_dbg(ei_local, hw, dev, "resetting" etc...);
next prev parent reply other threads:[~2013-11-06 23:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 20:56 [PATCH net-next] 8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature Matthew Whitehead
2013-11-06 23:49 ` Joe Perches [this message]
2013-11-07 21:42 ` Matthew Whitehead
2013-11-07 21:49 ` Joe Perches
2013-11-07 21:55 ` Matthew Whitehead
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383781753.7940.38.camel@joe-AO722 \
--to=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=tedheadster@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox