From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] net: wireless: iwlwifi: remove minor dead code
Date: Mon, 11 Nov 2013 14:42:38 +0100 [thread overview]
Message-ID: <1384177358.14334.13.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1384177312.14334.12.camel@jlt4.sipsolutions.net> (sfid-20131111_144211_754203_F365C56C)
On Mon, 2013-11-11 at 14:41 +0100, Johannes Berg wrote:
> > @@ -1150,7 +1149,14 @@ static irqreturn_t iwl_pcie_isr(int irq, void *data)
> > * or due to sporadic interrupts thrown from our NIC. */
> > if (!inta) {
> > IWL_DEBUG_ISR(trans, "Ignore interrupt, inta == 0\n");
> > - goto none;
> > + /* re-enable interrupts here since we don't have anything to
> > + * service. only Re-enable if disabled by irq and no
> > + * schedules tasklet.
> > + */
> > + if (test_bit(STATUS_INT_ENABLED, &trans_pcie->status) &&
> > + !trans_pcie->inta)
> > + iwl_enable_interrupts(trans);
> > + return IRQ_NONE;
>
> I don't really think duplicating this is really an improvement?
Err, sorry, not paying attention.
johannes
next prev parent reply other threads:[~2013-11-11 13:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-10 19:06 [PATCH] net: wireless: iwlwifi: remove minor dead code Michal Nazarewicz
[not found] ` <1384110397-24386-1-git-send-email-mpn-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2013-11-10 19:15 ` Sergei Shtylyov
2013-11-10 20:17 ` [PATCHv2] " Michal Nazarewicz
2013-11-11 13:41 ` Johannes Berg
2013-11-11 13:42 ` Johannes Berg [this message]
2013-11-12 0:01 ` [PATCHv2.1] " Michal Nazarewicz
[not found] ` <xa1tr4amwkrt.fsf-deATy8a+UHjQT0dZR+AlfA@public.gmane.org>
2013-11-12 5:24 ` Emmanuel Grumbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384177358.14334.13.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=emmanuel.grumbach@intel.com \
--cc=ilw@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mina86@mina86.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).