From: Ben Hutchings <bhutchings@solarflare.com>
To: Fugang Duan <B38611@freescale.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] net:fec: fix WARNING caused by lack of calls to dma_mapping_error()
Date: Thu, 14 Nov 2013 02:12:21 +0000 [thread overview]
Message-ID: <1384395141.29151.23.camel@bwh-desktop.uk.level5networks.com> (raw)
In-Reply-To: <1384392631-2059-1-git-send-email-B38611@freescale.com>
On Thu, 2013-11-14 at 09:30 +0800, Fugang Duan wrote:
[...]
> =============================================
> V2: add net_ratelimit() to limit map err message.
> use dma_sync_single_for_cpu() instead of dma_map_single().
> fix the issue that pass DMA addresses to __va() to get virture address.
> V1: initial send
> =============================================
>
> Signed-off-by: Fugang Duan <B38611@freescale.com>
> Reviewed-by: Ben Hutchings <ben@decadent.org.uk>
[...]
I'm sorry if I wasn't clear in my previous mail. The 'Reviewed-by' tag
means someone has reviewed *this version* of the patch and explicitly
said it was good, usually by writing that tag in their reply. You must
not add it just because someone reviewed and commented on an earlier
version of the patch.
I am not familiar with this driver or hardware so I would have to spend
some time looking at the surrounding code before being sure that it's
OK. I can't spare that time, and so I don't claim to have given this
patch a full review. But that's OK as you don't need my approval for
David to apply the patch. :-)
Please re-post without any reference to me.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2013-11-14 2:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 1:30 [PATCH] net:fec: fix WARNING caused by lack of calls to dma_mapping_error() Fugang Duan
2013-11-14 2:12 ` Ben Hutchings [this message]
2013-11-14 2:15 ` Fugang Duan
-- strict thread matches above, loose matches on Subject: below --
2013-11-12 2:54 Fugang Duan
2013-11-13 1:00 ` Ben Hutchings
2013-11-13 1:43 ` Ben Hutchings
2013-11-13 2:10 ` Fugang Duan
2013-11-13 3:02 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384395141.29151.23.camel@bwh-desktop.uk.level5networks.com \
--to=bhutchings@solarflare.com \
--cc=B38611@freescale.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox