netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: netdev@vger.kernel.org
Subject: [RFC 9/7] genetlink: make genl_ops flags a u8 and move to end
Date: Thu, 14 Nov 2013 15:01:38 +0100	[thread overview]
Message-ID: <1384437698.13941.24.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1384420486-8713-1-git-send-email-johannes@sipsolutions.net>

From: Johannes Berg <johannes.berg@intel.com>

To save some space in the struct on 32-bit systems,
make the flags a u8 (only 4 bits are used) and also
move them to the end of the struct.

This has no impact on 64-bit systems as alignment of
the struct in an array uses up the space anyway.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 include/net/genetlink.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/net/genetlink.h b/include/net/genetlink.h
index 0b6b10b..eddcdf2 100644
--- a/include/net/genetlink.h
+++ b/include/net/genetlink.h
@@ -110,15 +110,15 @@ static inline void genl_info_net_set(struct genl_info *info, struct net *net)
  * @ops_list: operations list
  */
 struct genl_ops {
-	u8			cmd;
-	u8			internal_flags;
-	unsigned int		flags;
 	const struct nla_policy	*policy;
 	int		       (*doit)(struct sk_buff *skb,
 				       struct genl_info *info);
 	int		       (*dumpit)(struct sk_buff *skb,
 					 struct netlink_callback *cb);
 	int		       (*done)(struct netlink_callback *cb);
+	u8			cmd;
+	u8			internal_flags;
+	u8			flags;
 };
 
 int __genl_register_family(struct genl_family *family);
-- 
1.8.4.rc3

  parent reply	other threads:[~2013-11-14 14:01 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-14  9:14 [RFC 0/7] genetlink: reduce ops size and complexity Johannes Berg
2013-11-14  9:14 ` [RFC 1/7] taskstats: use genl_register_family_with_ops() Johannes Berg
2013-11-14  9:14 ` [RFC 2/7] hsr: " Johannes Berg
2013-11-14  9:14 ` [RFC 3/7] ieee802154: " Johannes Berg
2013-11-14  9:14 ` [RFC 4/7] wimax: " Johannes Berg
2013-11-14  9:14 ` [RFC 5/7] genetlink: remove genl_register_ops/genl_unregister_ops Johannes Berg
2013-11-14  9:14 ` [RFC 6/7] genetlink: register family ops as array Johannes Berg
2013-11-14  9:14 ` [RFC 7/7] genetlink: allow making ops const Johannes Berg
2013-11-14 13:41 ` [RFC 8/7] genetlink: make all genl_ops users const Johannes Berg
2013-11-14 14:01 ` Johannes Berg [this message]
2013-11-14 14:36 ` [RFC 0/7] genetlink: reduce ops size and complexity Johannes Berg
2013-11-14 16:02 ` Johannes Berg
2013-11-14 16:14 ` [PATCH 0/9] genetlink: reduce ops size and complexity (v2) Johannes Berg
2013-11-14 16:14   ` [PATCH 1/9] taskstats: use genl_register_family_with_ops() Johannes Berg
2013-11-14 16:14   ` [PATCH 2/9] hsr: " Johannes Berg
2013-11-14 16:14   ` [PATCH 3/9] ieee802154: " Johannes Berg
2013-11-14 16:14   ` [PATCH 4/9] wimax: " Johannes Berg
2013-11-14 16:14   ` [PATCH 5/9] genetlink: remove genl_register_ops/genl_unregister_ops Johannes Berg
2013-11-14 16:14   ` [PATCH 6/9] genetlink: register family ops as array Johannes Berg
2013-11-14 16:14   ` [PATCH 7/9] genetlink: allow making ops const Johannes Berg
2013-11-14 16:14   ` [PATCH 8/9] genetlink: make all genl_ops users const Johannes Berg
2013-11-14 16:14   ` [PATCH 9/9] genetlink: make genl_ops flags a u8 and move to end Johannes Berg
2013-11-14 22:12   ` [PATCH 0/9] genetlink: reduce ops size and complexity (v2) David Miller
2013-11-15 13:18     ` Johannes Berg
2013-11-15 13:23       ` Johannes Berg
2013-11-15 14:45         ` Jamal Hadi Salim
2013-11-16  1:54         ` David Miller
2013-11-16  1:53       ` David Miller
2013-11-17  9:12         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384437698.13941.24.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).