From: Martin Topholm <mph@one.com>
To: pablo@netfilter.org
Cc: brouer@redhat.com, kaber@trash.net,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH 2/2] netfilter: synproxy: correct wscale option passing
Date: Thu, 14 Nov 2013 15:35:31 +0100 [thread overview]
Message-ID: <1384439731-16296-3-git-send-email-mph@one.com> (raw)
In-Reply-To: <1384439731-16296-1-git-send-email-mph@one.com>
Timestamp are used to store additional syncookie parameters such as sack,
ecn, and wscale. The wscale value we need to encode is the client's
wscale, since we can't recover that later in the session. Next overwrite
the wscale option so the later synproxy_send_client_synack will send
the backend's wscale to the client.
Signed-off-by: Martin Topholm <mph@one.com>
Reviewed-by: Jesper Dangaard Brouer <brouer@redhat.com>
---
net/netfilter/nf_synproxy_core.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/net/netfilter/nf_synproxy_core.c b/net/netfilter/nf_synproxy_core.c
index cdf4567..9858e3e 100644
--- a/net/netfilter/nf_synproxy_core.c
+++ b/net/netfilter/nf_synproxy_core.c
@@ -151,9 +151,10 @@ void synproxy_init_timestamp_cookie(const struct xt_synproxy_info *info,
opts->tsecr = opts->tsval;
opts->tsval = tcp_time_stamp & ~0x3f;
- if (opts->options & XT_SYNPROXY_OPT_WSCALE)
- opts->tsval |= info->wscale;
- else
+ if (opts->options & XT_SYNPROXY_OPT_WSCALE) {
+ opts->tsval |= opts->wscale;
+ opts->wscale = info->wscale;
+ } else
opts->tsval |= 0xf;
if (opts->options & XT_SYNPROXY_OPT_SACK_PERM)
next prev parent reply other threads:[~2013-11-14 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 14:35 [PATCH 0/2] Netfilter SYNPROXY mss and wscale bugfix Martin Topholm
2013-11-14 14:35 ` [PATCH 1/2] netfilter: synproxy: send mss option to backend Martin Topholm
2013-11-19 14:35 ` Pablo Neira Ayuso
2013-11-14 14:35 ` Martin Topholm [this message]
2013-11-19 14:35 ` [PATCH 2/2] netfilter: synproxy: correct wscale option passing Pablo Neira Ayuso
2013-11-14 14:41 ` [PATCH 0/2] Netfilter SYNPROXY mss and wscale bugfix Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384439731-16296-3-git-send-email-mph@one.com \
--to=mph@one.com \
--cc=brouer@redhat.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).