From: Joe Perches <joe@perches.com>
To: Alexander Aring <alex.aring@gmail.com>
Cc: alex.bluesman.smirnov@gmail.com,
linux-zigbee-devel@lists.sourceforge.net, werner@almesberger.net,
jukka.rissanen@linux.intel.com, dbaryshkov@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 4/6] 6lowpan: add udp warning for elided checksum
Date: Thu, 14 Nov 2013 08:32:01 -0800 [thread overview]
Message-ID: <1384446721.15774.5.camel@joe-AO722> (raw)
In-Reply-To: <1384444132-1427-5-git-send-email-alex.aring@gmail.com>
On Thu, 2013-11-14 at 16:48 +0100, Alexander Aring wrote:
> Bit 5 of "UDP LOWPAN_NHC Format" indicate that the checksum can be elided.
> The host need to calculate the udp checksum afterwards but this isn't
> supported right now.
[]
> diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
[]
> @@ -448,9 +448,14 @@ lowpan_uncompress_udp_header(struct sk_buff *skb, struct udphdr *uh)
> pr_debug("uncompressed UDP ports: src = %d, dst = %d\n",
> ntohs(uh->source), ntohs(uh->dest));
>
> - /* copy checksum */
> - memcpy(&uh->check, &skb->data[0], 2);
> - skb_pull(skb, 2);
> + /* checksum */
> + if (tmp & LOWPAN_NHC_UDP_CS_C) {
> + pr_debug("checksum elided currently not supported");
This looks like it could need ratelimiting
Also, it should end in "\n". Maybe use:
pr_debug_ratelimited("checksum elided currently not supported\n");
next prev parent reply other threads:[~2013-11-14 16:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 15:48 [PATCH net-next 0/6] 6lowpan: udp compression/uncompression fix Alexander Aring
2013-11-14 15:48 ` [PATCH net-next 1/6] 6lowpan: fix udp nullpointer dereferencing Alexander Aring
[not found] ` <1384444132-1427-2-git-send-email-alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-11-14 17:17 ` Werner Almesberger
2013-11-14 15:48 ` [PATCH net-next 2/6] 6lowpan: fix udp compress ordering Alexander Aring
[not found] ` <1384444132-1427-1-git-send-email-alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-11-14 15:48 ` [PATCH net-next 3/6] 6lowpan: fix udp byte ordering Alexander Aring
2013-11-14 15:48 ` [PATCH net-next 4/6] 6lowpan: add udp warning for elided checksum Alexander Aring
2013-11-14 16:32 ` Joe Perches [this message]
2013-11-14 16:50 ` Alexander Aring
2013-11-14 15:48 ` [PATCH net-next 5/6] 6lowpan: udp use lowpan_fetch_skb function Alexander Aring
2013-11-14 15:48 ` [PATCH net-next 6/6] 6lowpan: udp use subtraction on both conditions Alexander Aring
2013-11-14 16:19 ` [PATCH net-next 0/6] 6lowpan: udp compression/uncompression fix Eric Dumazet
2013-11-14 16:53 ` Alexander Aring
2013-11-14 22:06 ` David Miller
2013-11-15 5:12 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384446721.15774.5.camel@joe-AO722 \
--to=joe@perches.com \
--cc=alex.aring@gmail.com \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=jukka.rissanen@linux.intel.com \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=werner@almesberger.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).