From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: David Miller <davem@davemloft.net>,
e1000-devel <e1000-devel@lists.sourceforge.net>,
netdev@vger.kernel.org
Subject: Re: [E1000-devel] [PATCH net 2/6] e1000e: Validate hwtstamp_config completely before applying it
Date: Thu, 14 Nov 2013 08:36:36 -0800 [thread overview]
Message-ID: <1384446996.2160.4.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1384389698.29151.8.camel@bwh-desktop.uk.level5networks.com>
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
On Thu, 2013-11-14 at 00:41 +0000, Ben Hutchings wrote:
> e1000e_hwtstamp_ioctl() should validate all fields of hwtstamp_config
> before making any changes. Currently it copies the configuration to
> the e1000_adapter structure before validating it at all.
>
> Change e1000e_config_hwtstamp() to take a pointer to the
> hwstamp_config and to copy the config after validating it.
>
> Compile-tested only.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> drivers/net/ethernet/intel/e1000e/netdev.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-14 16:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 0:39 [PATCH net 0/6] net_tstamp: Validate hwtstamp_config completely before applying it Ben Hutchings
2013-11-14 0:40 ` [PATCH net 1/6] tg3: " Ben Hutchings
2013-11-14 0:55 ` Nithin Nayak Sujir
2013-11-14 0:41 ` [PATCH net 2/6] e1000e: " Ben Hutchings
2013-11-14 16:36 ` Jeff Kirsher [this message]
2013-11-14 0:42 ` [PATCH net 3/6] pch_gbe: " Ben Hutchings
2013-11-14 7:21 ` Richard Cochran
2013-11-14 7:27 ` Richard Cochran
2013-11-14 8:17 ` David Miller
2013-11-14 0:43 ` [PATCH net 4/6] stmmac: " Ben Hutchings
2013-11-19 5:26 ` Giuseppe CAVALLARO
2013-11-19 5:55 ` Rayagond K
2013-11-14 0:47 ` [PATCH net 5/6] ti_cpsw: " Ben Hutchings
2013-11-14 12:49 ` Mugunthan V N
2013-11-14 0:48 ` [PATCH net 6/6] ixp4xx_eth: " Ben Hutchings
2013-11-14 6:53 ` [PATCH net 0/6] net_tstamp: " David Miller
2013-11-14 13:26 ` Richard Cochran
2013-11-14 21:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384446996.2160.4.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).