* [PATCH net] xfrm: Release dst if this dst is improper for vti tunnel
@ 2013-11-19 8:53 Fan Du
2013-11-19 20:51 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Fan Du @ 2013-11-19 8:53 UTC (permalink / raw)
To: steffen.klassert, saurabh.mohan; +Cc: davem, netdev
After searching rt by the vti tunnel dst/src parameter,
if this rt has neither attached to any transformation
nor the transformation is not tunnel oriented, this rt
should be released back to ip layer.
otherwise causing dst memory leakage.
Signed-off-by: Fan Du <fan.du@windriver.com>
---
net/ipv4/ip_vti.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv4/ip_vti.c b/net/ipv4/ip_vti.c
index 5d9c845..52b802a 100644
--- a/net/ipv4/ip_vti.c
+++ b/net/ipv4/ip_vti.c
@@ -126,6 +126,7 @@ static netdev_tx_t vti_tunnel_xmit(struct sk_buff *skb, struct net_device *dev)
if (!rt->dst.xfrm ||
rt->dst.xfrm->props.mode != XFRM_MODE_TUNNEL) {
dev->stats.tx_carrier_errors++;
+ ip_rt_put(rt);
goto tx_error_icmp;
}
tdev = rt->dst.dev;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] xfrm: Release dst if this dst is improper for vti tunnel
2013-11-19 8:53 [PATCH net] xfrm: Release dst if this dst is improper for vti tunnel Fan Du
@ 2013-11-19 20:51 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-11-19 20:51 UTC (permalink / raw)
To: fan.du; +Cc: steffen.klassert, saurabh.mohan, netdev
From: Fan Du <fan.du@windriver.com>
Date: Tue, 19 Nov 2013 16:53:28 +0800
> After searching rt by the vti tunnel dst/src parameter,
> if this rt has neither attached to any transformation
> nor the transformation is not tunnel oriented, this rt
> should be released back to ip layer.
>
> otherwise causing dst memory leakage.
>
> Signed-off-by: Fan Du <fan.du@windriver.com>
Good catch, applied and queued up for -stable, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-19 20:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-19 8:53 [PATCH net] xfrm: Release dst if this dst is improper for vti tunnel Fan Du
2013-11-19 20:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).