Netdev List
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Michael Opdenacker <michael.opdenacker@free-electrons.com>,
	Johannes Berg <johannes.berg@intel.com>
Cc: inaky.perez-gonzalez@intel.com, linux-wimax@intel.com,
	davem@davemloft.net, wimax@linuxwimax.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wimax: remove dead code
Date: Wed, 20 Nov 2013 20:17:49 -0800	[thread overview]
Message-ID: <1385007469.2164.39.camel@joe-AO722> (raw)
In-Reply-To: <1385005391-18379-1-git-send-email-michael.opdenacker@free-electrons.com>

On Thu, 2013-11-21 at 04:43 +0100, Michael Opdenacker wrote:
> This removes a code line that is between a "return 0;" and an error label.
> This code line can never be reached.

Adding Johannes Berg who added this oversight.

> Found by Coverity (CID: 1130529)
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> ---
>  net/wimax/stack.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/wimax/stack.c b/net/wimax/stack.c
> index ef2191b969a7..ec8b577db135 100644
> --- a/net/wimax/stack.c
> +++ b/net/wimax/stack.c
> @@ -610,7 +610,6 @@ int __init wimax_subsys_init(void)
>  	d_fnend(4, NULL, "() = 0\n");
>  	return 0;
>  
> -	genl_unregister_family(&wimax_gnl_family);
>  error_register_family:
>  	d_fnend(4, NULL, "() = %d\n", result);
>  	return result;

  reply	other threads:[~2013-11-21  4:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-21  3:43 [PATCH] wimax: remove dead code Michael Opdenacker
2013-11-21  4:17 ` Joe Perches [this message]
2013-11-21  7:27   ` Johannes Berg
2013-11-21 18:19     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385007469.2164.39.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=davem@davemloft.net \
    --cc=inaky.perez-gonzalez@intel.com \
    --cc=johannes.berg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wimax@intel.com \
    --cc=michael.opdenacker@free-electrons.com \
    --cc=netdev@vger.kernel.org \
    --cc=wimax@linuxwimax.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox